-
Notifications
You must be signed in to change notification settings - Fork 24
Pull in Git history from runC repository #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Solomon Hykes <solomon@docker.com>
This was such a good resource in Docker that it would be a shame to lose it. Unfortunately, we can't just link to the corresponding information in the Docker project as a number of aspects are bound to be different here. Docker-DCO-1.1-Signed-off-by: Glyn Normington <gnormington@gopivotal.com> (github: glyn)
Docker-DCO-1.1-Signed-off-by: Glyn Normington <gnormington@gopivotal.com> (github: glyn)
Docker-DCO-1.1-Signed-off-by: Glyn Normington <gnormington@gopivotal.com> (github: glyn)
Docker-DCO-1.1-Signed-off-by: Glyn Normington <gnormington@gopivotal.com> (github: glyn)
Docker-DCO-1.1-Signed-off-by: Glyn Normington <gnormington@gopivotal.com> (github: glyn)
Docker-DCO-1.1-Signed-off-by: Glyn Normington <gnormington@gopivotal.com> (github: glyn)
This is based on feedback from @rjnagal. Docker-DCO-1.1-Signed-off-by: Glyn Normington <gnormington@gopivotal.com> (github: glyn)
Docker-DCO-1.1-Signed-off-by: Glyn Normington <gnormington@gopivotal.com> (github: glyn)
Docker-DCO-1.1-Signed-off-by: Glyn Normington <gnormington@gopivotal.com> (github: glyn)
Docker-DCO-1.1-Signed-off-by: Glyn Normington <gnormington@gopivotal.com> (github: glyn)
These changes were suggested by @vmarmol. Docker-DCO-1.1-Signed-off-by: Glyn Normington <gnormington@gopivotal.com> (github: glyn)
Docker-DCO-1.1-Signed-off-by: Victor Marmol <vmarmol@google.com> (github: vmarmol)
Docker-DCO-1.1-Signed-off-by: Victor Marmol <vmarmol@google.com> (github: vmarmol)
Docker-DCO-1.1-Signed-off-by: Andrew Page <admwiggin@gmail.com> (github: tianon)
Signed-off-by: Dave Tucker <dave@dtucker.co.uk>
Docker-DCO-1.1-Signed-off-by: Mrunal Patel <mrunalp@gmail.com> (github: mrunalp)
Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
This moves much of the documentation on contributing and maintainer the codebase from the libcontainer sub directory to the root of the repo. Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
This makes some changes to the maintainer's guide and roles within the project. It removed the concept of a BDFL and carries over the chief maintainer role into the project. BDFL sucks and we can do better and these changed help to make many more things specific around adding new maintainers and removing them as well. Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
Resolving trivial "runC" -> "the project" and similar changes that were made in the project-template version. Also remove the Docker copyright notice from LICENSE to match the project-template version. Conflicts: CONTRIBUTING.md LICENSE MAINTAINERS_GUIDE.md
Contributor
|
@crosbymichael any opinion here? I don't think we need the full history |
Member
|
Ya, not really a need here as we are already modifying it. Its nice to have a fresh and clean history for these docs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CONTRIBUTING.mdandMAINTAINERS_GUIDE.mdfrom #1 came out ofopencontainers/runc but lost their history. Since dropping history
like that makes Signed-off-by tags less useful, this PR restores the
history extracted from the runC repository. The branch was
constructed with:
Pulling in the
LICENSEas well makes the Signed-off-by assertionsuseful, even though that's (almost) the same content that already landed in
this repo via ad517c3.