This repository was archived by the owner on Jan 15, 2026. It is now read-only.
MAINTAINERS: add Aleksa Sarai #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Much of the work I've done in umoci is effectively rewriting parts of image-tools so that they are better designed and stable. I feel very strongly that most (if not all) of umoci should live within this project. As such, I feel that I'm sufficiently familiar with all of the many implementation details necessary to correctly and sanely implement the OCI image specification. Signed-off-by: Aleksa Sarai <asarai@suse.de>
Contributor
|
Just as a note you have contributed to image-tools in the past: cc: @opencontainers/image-tools-maintainers |
Member
Author
|
Before we merge this, there is some discussion about the future of |
Member
|
SGTM
…On Thu, Feb 16, 2017 at 9:33 AM, Aleksa Sarai ***@***.***> wrote:
Before we merge this, there is some discussion about the future of umoci
and image-tools that we should hash out on the mailing list first. I'll
send a mail about it this afternoon/evening.
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
<#118 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEF6WKKs2IQeBj06zuWvq7nkwGBwIhJks5rdF4fgaJpZM4MC-qE>
.
|
Contributor
|
@cyphar You beat me to it! LGTM |
Contributor
|
I've updated the commit to track the progress of the vote! Good luck! |
Member
|
LGTM |
4 similar comments
|
LGTM |
Contributor
|
LGTM |
Member
|
LGTM |
Contributor
|
LGTM |
Contributor
|
LGTM
…On 16 February 2017 at 17:23, xiekeyang ***@***.***> wrote:
LGTM
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#118 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACewN3O34X4FlxJFX3tTSD7U-ISWA5HLks5rdPZ_gaJpZM4MC-qE>
.
|
Contributor
|
7/9 votes is good enough to meet the 2/3 requirement. Welcome @cyphar as an @opencontainers/image-tools-maintainers ! |
Merged
wking
added a commit
to wking/oci-project-template
that referenced
this pull request
Mar 20, 2017
Email-based voting seems to be a blocker for Michael, who prefers PR-based voting for non-spec projects [1]. And the image-tools maintainers had a PR-only vote to add Aleksa as a maintainer [2]. Specifications are still recommended to only use dev@ (for increased visibility among folks with only peripheral involvement, e.g. spec consumers). But non-spec projects can backtrack more easily from decisions which have negative impacts, so we don't have to push them towards dev@ as firmly. Adopting this more-relaxed approach should help reduce barriers to non-spec projects adopting the vanilla governance procedures, which may move us towards more consistency between OCI projects [3]. [1]: http://ircbot.wl.linuxfoundation.org/eavesdrop/%23opencontainers/%23opencontainers.2017-03-20.log.html#t2017-03-20T19:54:38 [2]: opencontainers/image-tools#118 (comment) Subject: MAINTAINERS: add Aleksa Sarai [3]: opencontainers#4 Subject: Apply consistent project template across OCI Signed-off-by: W. Trevor King <wking@tremily.us>
wking
added a commit
to wking/oci-project-template
that referenced
this pull request
Mar 20, 2017
Email-based voting seems to be a blocker for Michael, who prefers PR-based voting for non-spec projects [1]. And the image-tools maintainers had a PR-only vote to add Aleksa as a maintainer [2]. Specifications are still recommended to only use dev@ (for increased visibility among folks with only peripheral involvement, e.g. spec consumers). But non-spec projects can backtrack more easily from decisions which have negative impacts, so we don't have to push them towards dev@ as firmly. Adopting this more-relaxed approach should help reduce barriers to non-spec projects adopting the vanilla governance procedures, which may move us towards more consistency between OCI projects [3]. [1]: http://ircbot.wl.linuxfoundation.org/eavesdrop/%23opencontainers/%23opencontainers.2017-03-20.log.html#t2017-03-20T19:54:38 [2]: opencontainers/image-tools#118 (comment) Subject: MAINTAINERS: add Aleksa Sarai [3]: opencontainers#4 Subject: Apply consistent project template across OCI Signed-off-by: W. Trevor King <wking@tremily.us>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Much of the work I've done in umoci is effectively rewriting parts of
image-tools so that they are better designed and stable. I feel very
strongly that most (if not all) of umoci should live within this
project.
As such, I feel that I'm sufficiently familiar with all of the many
implementation details necessary to correctly and sanely implement the
OCI image specification.
Signed-off-by: Aleksa Sarai asarai@suse.de