-
Notifications
You must be signed in to change notification settings - Fork 677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
serialization: remove combined spec #95
Conversation
The combined spec isn't really part of the image format and introduces new objects that we don't have a schema for. Largely I think that it should be replaced by something like the image layout. opencontainers#94 Signed-off-by: Brandon Philips <brandon.philips@coreos.com>
@wking AFAIK this combined format is never used on the wire anywhere. It is only in |
On Fri, May 27, 2016 at 12:23:05PM -0700, Brandon Philips wrote:
I'm not sure how far image-spec's compatibility goal extends ;). #94 Personally, I'm not really a backwards-compat-in-the-spec guy ;). As |
The implication here is that we lose compatibility with the For testing purposes, OCI (tools or here) should have a way of processing The format in #94 is wildly better, but we really need to leverage the existing tools for bootstrap of OCI. I do however agree that this doesn't really belong in the image config specification. |
@stevvooe Is there a library or something for parsing all of those formats in docker save/load? We can certainly put them into oci-image-tool. Would you be OK merging this PR if I filed an issue to add that as an oci-image-tool feature? |
OK, I will add language to #94. Wanna LGTM this? |
LGTM |
1 similar comment
LGTM |
The combined spec isn't really part of the image format and introduces
new objects that we don't have a schema for. Largely I think that it
should be replaced by something like the image layout.
#94
Signed-off-by: Brandon Philips brandon.philips@coreos.com