Modify the test's config type

[zhouhao3]

When I execute the test command, I get the following warning, so I made the following changes.
$ go test
warning: config sha256:5359a4f250650c20227055957e353e8f8a74152f35fe36f00b6b1f9fc19c8861 has an unknown media type: application/octet-stream

Signed-off-by: zhouhao zhouhao@cn.fujitsu.com

[wking]

Have you tested this? I expect the curl call will not succeed. I think the right solution to this problem is to make these child-media-type checks optional, with something like a strict option. More background in opencontainers/image-tools#66, #403, and #452.

[zhouhao3]

I have tested the changes and the results are correct：

go test
PASS
ok _/home/zhouhao/image-spec/schema 0.033s

[wking]

On Tue, Jan 03, 2017 at 05:00:57PM -0800, Zhou Hao wrote:

go test
PASS

I agree that the tests pass with your 3607393, but the point of these tests is to show that the current OCI spec is compatible with existing Docker-hub blob instances with minimal media type replacements. If you change the Docker-hub blobs locally, you break that. Using the token fetching comment from #370:

$ TOKEN=$(curl https://auth.docker.io/token\?service\=registry.docker.io\&scope\=repository:library/docker:pull  | jq -r .token)
$ curl -sILH "Authorization: Bearer ${TOKEN}" -H "Accept: application/vnd.docker.distribution.manifest.v2+json" https://registry-1.docker.io/v2/library/docker/manifests/sha256:888206c77cd2811ec47e752ba291e5b7734e3ef137dfd222daadaca39a9f17bc | head -n1
HTTP/1.1 200 OK
$ curl -sILH "Authorization: Bearer ${TOKEN}" -H "Accept: application/vnd.docker.distribution.manifest.v2+json" https://registry-1.docker.io/v2/library/docker/manifests/sha256:d901d5244c94db8151415bf3a1d3a0b10e7468e4997786b01c287cbcbaeca446 | head -n1
HTTP/1.1 404 Not Found

The tests in this backwards-compat file need to be blobs you can successfully pull from the Docker hub, not ones that 404.

[zhouhao3]

Why do I enter the results of both cases are HTTP/1.1 200 Connection established

[wking]

The "Connection established" line is probably from a proxy. You'll see the 404 if you drop the head calls.

[zhouhao3]

However, when the modified mediatype, we must then modify the digest. This will resolve the warning

[wking]

However, when the modified mediatype, we must then modify the digest. This will resolve the warning

To satisfy the spirit of these compat tests, you cannot modify the source content (or its digest) at all. The point is that these examples are caught-in-the-wild blobs, and that after flushing that wild-caught content through convertFormats you get a valid OCI blob. The compatibility claim will be less convincing if it becomes “we edit the wild blob by hand and then flush it through convertFormats so we're compatible” ;).

And you do get a valid OCI blob (because we only SHOULD application/vnd.oci.image.config.v1+json for a manifest's config descriptor). The “has an unknown media type” error you get is because the current tests are stricter than the spec and provide no way to select between “MUST all compliant handlers support this blob?” and “is this blob valid?”.

[zhouhao3]

thanks,updated.

[philips]

LGTM

[vbatts]

LGTM