-
Notifications
You must be signed in to change notification settings - Fork 638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
schema: add checkPlatform #469
Conversation
Signed-off-by: zhouhao <zhouhao@cn.fujitsu.com>
These are SHOULDs, not MUSTs. Why should we validate them? |
i'm okay with them being checked, but not to FAIL a validation. |
On Wed, Nov 30, 2016 at 01:42:16PM -0800, Vincent Batts wrote:
i'm okay with them being _checked_, but not to FAIL a validation.
+1. We should probably table this until we settle on strict handling
(see the discussion in opencontainers/image-spec#452 and me trying to
outline the issue in opencontainers/image-tools#66).
|
Because these two are required attributes, and as the specification says: The name of the operating system which the image is built to run on. If it is the verification of the system, only by JSON to restrict the type is not rigorous, it should be the value of its specific judgment. |
Due to my mistakes, resulting in this PR can not be updated, I will close this, and then open a new PR. |
Fixes opencontainers/image-tools#39
Signed-off-by: zhouhao zhouhao@cn.fujitsu.com