manifest-list.md: fix some spelling error #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrumanLing
changed the title
wking
reviewed
Oct 28, 2016
| @@ -16,7 +16,7 @@ This section defines the `application/vnd.oci.image.manifest.list.v1+json` [medi | |||
|
|
|||
| This REQUIRED property contains the media type of the manifest list. | |||
| For this version of the specification, this MUST be set to `application/vnd.oci.image.manifest.list.v1+json`. | |||
| For the media type(s) that this is compatible with see the [matrix](media-types.md#compatibility-matrix). | |||
| For the media type(s) that this specification is compatible with, see the [matrix](media-types.md#compatibility-matrix). | |||
There was a problem hiding this comment.
I'm fine with the new comma, but against the “specification” insertion. In this sentence, “this” is referring to application/vnd.oci.image.manifest.list.v1+json from the previous sentence. If the “this” in this sentence is unclear, I'd rather replace it with the media type:
For the media type(s) that
application/vnd.oci.image.manifest.list.v1+jsonis compatible with, see the compatibility matrix.
Signed-off-by: Ling FaKe <lingfake@huawei.com>
|
@wking Thanks for your suggestion, I have done it, PTAL. |
|
LGTM |
1 similar comment
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ling FaKe lingfake@huawei.com