manifest: List media types supported by descriptor references #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wking
force-pushed
the
media-type-requirements
branch
from
17c80a2
to
ae138eb
Compare
|
This seems to go against the compatibility matrix |
|
Yes, please add the nondistributable to the compat matrix. Thanks! |
|
On Tue, Sep 13, 2016 at 12:12:19PM -0700, Brandon Philips wrote:
Should be covered by the just-landed #233. I'll rebase around that |
|
On Tue, Sep 13, 2016 at 12:00:57PM -0700, Vincent Batts wrote:
Maybe I'm misunderstanding the compatibility matrix. I had thought it |
wking
added a commit
to wking/image-spec
that referenced
this pull request
Sep 14, 2016
Linking the files from Makefile's DOC_FILES in their listed order. Link text generally follows the headers used by the linked document. Informative stuff (for image and implementation authors) is indented under the README (although I'm not sure there's consensus on whether media-types.md is normative or informative [1]). [1]: opencontainers#304 (comment) Subject: manifest: List media types supported by descriptor references Signed-off-by: W. Trevor King <wking@tremily.us>
|
I now have similar confusion to #304 (comment) so a clarification would be appreciated. |
wking
force-pushed
the
media-type-requirements
branch
from
ae138eb
to
a3b9724
Compare
|
On Tue, Sep 13, 2016 at 12:22:54PM -0700, W. Trevor King wrote:
|
wking
added a commit
to wking/image-spec
that referenced
this pull request
Sep 15, 2016
Linking the files from Makefile's DOC_FILES in their listed order. Link text generally follows the headers used by the linked document. Informative stuff (for image and implementation authors) is indented under the README (although I'm not sure there's consensus on whether media-types.md is normative or informative [1]). [1]: opencontainers#304 (comment) Subject: manifest: List media types supported by descriptor references Signed-off-by: W. Trevor King <wking@tremily.us>
|
This patch LGTM based on my understanding so would love to hear what I'm missing.. |
This was referenced Sep 18, 2016
|
LGTM |
1 similar comment
|
LGTM |
|
gd... now it needs a rebase? how did github not show that right before? ... rebase please |
wking
force-pushed
the
media-type-requirements
branch
from
a3b9724
to
3b6f413
Compare
Require implementations to support these media types (although an implementation which also supports additional media types is still compliant). Suggest portable manifests and manifest lists stick to these types so the can rely on implementation support. A manifest(-list) can safely use a type from outside the list if the author expects the implementation to support the extension type (e.g. application/vnd.docker.image.rootfs.diff.tar.gzip). But how that out-of-band expectation is setup is beyond the scope of this specification. Signed-off-by: W. Trevor King <wking@tremily.us>
wking
force-pushed
the
media-type-requirements
branch
from
3b6f413
to
b1f1d9c
Compare
|
LGTM |
|
lgtm |
wking
added a commit
to wking/image-spec
that referenced
this pull request
Oct 16, 2016
I typo'd these in b1f1d9c (manifest: List media types supported by descriptor references, 2016-09-13, opencontainers#304). Signed-off-by: W. Trevor King <wking@tremily.us>
This was referenced Oct 16, 2016
dattgoswami9lk5g
added a commit
to dattgoswami9lk5g/bremlinr
that referenced
this pull request
Jun 6, 2022
Linking the files from Makefile's DOC_FILES in their listed order. Link text generally follows the headers used by the linked document. Informative stuff (for image and implementation authors) is indented under the README (although I'm not sure there's consensus on whether media-types.md is normative or informative [1]). [1]: opencontainers/image-spec#304 (comment) Subject: manifest: List media types supported by descriptor references Signed-off-by: W. Trevor King <wking@tremily.us>
7c00d
pushed a commit
to 7c00d/J1nHyeockKim
that referenced
this pull request
Jun 6, 2022
Linking the files from Makefile's DOC_FILES in their listed order. Link text generally follows the headers used by the linked document. Informative stuff (for image and implementation authors) is indented under the README (although I'm not sure there's consensus on whether media-types.md is normative or informative [1]). [1]: opencontainers/image-spec#304 (comment) Subject: manifest: List media types supported by descriptor references Signed-off-by: W. Trevor King <wking@tremily.us>
7c00d
added a commit
to 7c00d/J1nHyeockKim
that referenced
this pull request
Jun 6, 2022
Linking the files from Makefile's DOC_FILES in their listed order. Link text generally follows the headers used by the linked document. Informative stuff (for image and implementation authors) is indented under the README (although I'm not sure there's consensus on whether media-types.md is normative or informative [1]). [1]: opencontainers/image-spec#304 (comment) Subject: manifest: List media types supported by descriptor references Signed-off-by: W. Trevor King <wking@tremily.us>
laventuraw
added a commit
to laventuraw/Kihara-tony0
that referenced
this pull request
Jun 6, 2022
Linking the files from Makefile's DOC_FILES in their listed order. Link text generally follows the headers used by the linked document. Informative stuff (for image and implementation authors) is indented under the README (although I'm not sure there's consensus on whether media-types.md is normative or informative [1]). [1]: opencontainers/image-spec#304 (comment) Subject: manifest: List media types supported by descriptor references Signed-off-by: W. Trevor King <wking@tremily.us>
tomalopbsr0tt
added a commit
to tomalopbsr0tt/fabiojosej
that referenced
this pull request
Oct 6, 2022
Linking the files from Makefile's DOC_FILES in their listed order. Link text generally follows the headers used by the linked document. Informative stuff (for image and implementation authors) is indented under the README (although I'm not sure there's consensus on whether media-types.md is normative or informative [1]). [1]: opencontainers/image-spec#304 (comment) Subject: manifest: List media types supported by descriptor references Signed-off-by: W. Trevor King <wking@tremily.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Require implementations to support these media types (although an implementation which also supports additional media types is still compliant). Suggest portable manifests and manifest lists stick to these types so the can rely on implementation support.
A manifest(-list) can safely use a type from outside the list if the author expects the implementation to support the extension type (e.g. application/vnd.docker.image.rootfs.diff.tar.gzip). But how that out-of-band expectation is setup is beyond the scope of this specification.
Previous discussion in #286 and a few other one-off comments ;).