Skip to content

Commit

Permalink
config, conversion: move volume behavior to conversion
Browse files Browse the repository at this point in the history
Signed-off-by: Stephen J Day <stephen.day@docker.com>
  • Loading branch information
stevvooe committed Jun 21, 2017
1 parent d4cf636 commit 8f42721
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
2 changes: 0 additions & 2 deletions config.md
Original file line number Diff line number Diff line change
Expand Up @@ -149,8 +149,6 @@ Note: Any OPTIONAL field MAY also be set to null, which is equivalent to being a
- **Volumes** *object*, OPTIONAL

A set of directories describing where the process is likely write data specific to a container instance.
Implementations SHOULD provide mounts for these locations such that application data is not written to the container's root filesystem.
If a _new_ image is created from a container based on the image described by this configuration, data in these paths SHOULD NOT be included in the _new_ image.
**NOTE:** This JSON structure value is unusual because it is a direct JSON serialization of the Go type `map[string]struct{}` and is represented in JSON as an object mapping its keys to an empty object.

- **WorkingDir** *string*, OPTIONAL
Expand Down
5 changes: 4 additions & 1 deletion conversion.md
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,10 @@ A compliant configuration converter SHOULD provide a way for users to extract th

1. The runtime configuration does not have a corresponding field for this image field.
However, converters SHOULD set the [`org.opencontainers.image.exposedPorts` annotation](#config.exposedports).
2. If a converter implements conversion for this field using mountpoints, it SHOULD set the `destination` of the mountpoint to the value specified in `Config.Volumes`.
2. Implementations SHOULD provide mounts for these locations such that application data is not written to the container's root filesystem.
If a converter implements conversion for this field using mountpoints, it SHOULD set the `destination` of the mountpoint to the value specified in `Config.Volumes`.
An implementation MAY seed the contents of the mount with data in the image at the same location.
If a _new_ image is created from a container based on the image described by this configuration, data in these paths SHOULD NOT be included in the _new_ image.
The other `mounts` fields are platform and context dependent, and thus are implementation-defined.
Note that the implementation of `Config.Volumes` need not use mountpoints, as it is effectively a mask of the filesystem.

Expand Down

0 comments on commit 8f42721

Please sign in to comment.