Support referrers to a missing manifest #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudo-bmitch
requested review from
dmcgowan,
jzelinskie,
jonjohnsonjr,
jdolitsky,
mikebrow,
stevvooe and
vbatts
as code owners
|
cc @jonjohnsonjr and @sajayantony |
mikebrow
requested changes
Nov 14, 2023
Signed-off-by: Brandon Mitchell <git@bmitch.net>
sudo-bmitch
force-pushed
the
pr-referrers-to-missing
branch
from
f695222 to
0a867d6
Compare
jdolitsky
approved these changes
Dec 14, 2023
jonjohnsonjr
approved these changes
Jan 4, 2024
|
@mikebrow was your feedback addressed, or is there anything else I'm missing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the discussions of whether to require registries to accept a manifest with a subject pointing to missing digest, there was a use case mentioned of pushing metadata to a separate repo from the images. In cases where the registry does support pushing these manifests, the empty response to the referrers API breaks that use case. It also doesn't provide any value for those that want to validate the subject descriptor. So I propose removing that exception from the spec.
The changes to the conformance tests can be gated behind configuration variables if registries have the option to validate the subject field in a future version of the spec.