Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conformance: skip check (by default) for zero layers in image manifest #421

Merged
merged 2 commits into from
Jun 21, 2023
Merged

conformance: skip check (by default) for zero layers in image manifest #421

merged 2 commits into from
Jun 21, 2023

Commits on Jun 21, 2023

  1. conformance: always run but warn if empty layer manifest not supported 

    As per image-spec, since this is a SHOULD (hence recommended) and now
turned off by default.

https://raw.githubusercontent.com/opencontainers/image-spec/main/manifest.md
===

    layers array of objects

    Each item in the array MUST be a descriptor. For portability, layers
    SHOULD have at least one entry.

===

One can enable this test by setting env var:
OCI_SKIP_EMPTY_LAYER_PUSH_TEST=0

Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>
    @rchincha
    rchincha committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    8879931 View commit details
    Browse the repository at this point in the history

  2. conformance: delete the empty manifest in teardown 

    emptyLayerManifest is being pushed but not deleted during teardown

Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>
    @rchincha
    rchincha committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    1ea7ad4 View commit details
    Browse the repository at this point in the history