conformance.test01Pull: Check client errors before using response object #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmoylan
requested review from
dmcgowan,
jzelinskie,
jonjohnsonjr,
jdolitsky,
mikebrow,
stevvooe,
sudo-bmitch and
vbatts
as code owners
Previously, if the client.Do returned an (ignored) error and nil response, the subsequent usages of `resp` panic. Signed-off-by: Brad Moylan <bmoylan@palantir.com>
bmoylan
force-pushed
the
bm/check-pull-errors
branch
from
409ef91
to
315c7e0
Compare
jonjohnsonjr
approved these changes
Oct 13, 2022
jdolitsky
approved these changes
Oct 17, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if the client.Do returned an (ignored) error and nil response, the subsequent usages of
resppanic.Signed-off-by: Brad Moylan bmoylan@palantir.com