Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Registries MUST accept refers to unknown manifests #341

Merged
merged 1 commit into from
Sep 14, 2022
Merged

Registries MUST accept refers to unknown manifests #341

merged 1 commit into from
Sep 14, 2022

Conversation

sudo-bmitch
Copy link
Contributor

Resolves #340

Signed-off-by: Brandon Mitchell git@bmitch.net

rchincha
rchincha reviewed Sep 8, 2022
View reviewed changes
spec.md Outdated Show resolved Hide resolved
@sudo-bmitch sudo-bmitch added this to the v1.1.0 milestone Sep 8, 2022
@sudo-bmitch
Registries MUST accept refers to unknown manifests
19e5fa5 
Signed-off-by: Brandon Mitchell <git@bmitch.net>
mikebrow
mikebrow approved these changes Sep 12, 2022
View reviewed changes
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM...

noting here that this MUST requirement does not mean the registry can't garbage collect manifests such as these with a refers digest reference that either no longer or never existed in the registry..

@sudo-bmitch sudo-bmitch merged commit b5e110d into opencontainers:main Sep 14, 2022
@sudo-bmitch sudo-bmitch deleted the pr-refers-must-accept branch September 14, 2022 09:43
@jdolitsky jdolitsky mentioned this pull request Sep 15, 2022
Merged
@dmcgowan dmcgowan mentioned this pull request Aug 17, 2023
Open
@sudo-bmitch sudo-bmitch mentioned this pull request Feb 1, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rchincha rchincha rchincha left review comments

@dmcgowan dmcgowan dmcgowan approved these changes

@sajayantony sajayantony sajayantony approved these changes

@mikebrow mikebrow mikebrow approved these changes

@jzelinskie jzelinskie Awaiting requested review from jzelinskie jzelinskie is a code owner

@jonjohnsonjr jonjohnsonjr Awaiting requested review from jonjohnsonjr jonjohnsonjr is a code owner

@jdolitsky jdolitsky Awaiting requested review from jdolitsky jdolitsky is a code owner

@stevvooe stevvooe Awaiting requested review from stevvooe stevvooe is a code owner

@vbatts vbatts Awaiting requested review from vbatts

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.1.0
5 participants
@sudo-bmitch @dmcgowan @sajayantony @mikebrow @rchincha