Conformance tests: delete emptylayer manifest too

[edigaryev]

Otherwise the Delete config blob created in tests step will fail (even when using OCI_DELETE_MANIFEST_BEFORE_BLOBS=1), because the configuration blob that it deletes is also referenced by the emptylayer manifest:

distribution-spec/conformance/setup.go

Lines 256 to 263 in 7be5e85

	emptyLayerManifest := imagespec.Manifest{
	Config: imagespec.Descriptor{
	MediaType: "application/vnd.oci.image.config.v1+json",
	Digest: godigest.Digest(configs[1].Digest),
	Size: int64(len(configs[1].Content)),
	},
	Layers: []imagespec.Descriptor{},
	}

[jdolitsky]

Ran this changeset against bundlebar, and failing with:

~~~ RESPONSE ~~~
STATUS       : 400 Bad Request
RECEIVED AT  : 2021-12-01T11:05:28.706046-06:00
TIME DURATION: 31.481292ms
HEADERS      :
	Connection: keep-alive
	Content-Length: 94
	Content-Type: application/json; charset=utf-8
	Date: Wed, 01 Dec 2021 17:05:28 GMT
	Server: bundle.bar
	X-Content-Type-Options: nosniff
	X-Request-Id: 778b424b-7721-46ef-9b29-7554206e500d
BODY         :
{
   "errors": [
      {
         "code": "UNSUPPORTED",
         "message": "deletion by tag is not supported",
         "detail": null
      }
   ]
}

I beilieve we need to allow that if the delete by tag returns 400, it is a UNSUPPORTED error.

Similar to what is done in lines 97-102 here:

distribution-spec/conformance/04_management_test.go

Line 97 in cd0399f

if resp.StatusCode() == http.StatusBadRequest {

[edigaryev]

I beilieve we need to allow that if the delete by tag returns 400, it is a UNSUPPORTED error.

It seems like a more appropriate solution would be to delete that manifest by a digest, because we still want it to be gone to be free of dependencies, see 40b4c03.

Also, what is a "bundlebar" and how can I run the conformance tests against it?

[edigaryev]

@jdolitsky would you mind giving this a look once more? Thanks!

[sudo-bmitch]

LGTM

[sudo-bmitch]

We need a condition on this second delete, checking whether skipEmptyLayerTest is false before running it.

[sudo-bmitch]

See #421 for while this will be a bigger issue going forward.

[rchincha]

Have fixed this in #421 since hitting this issue there as well.

[rchincha]

Why not move this into setup.go or a utils.go/common.go
Other tests could use this too.

[jdolitsky]

closing as outdated, will address as we make further updates in conformance in the coming ~ week