spec: adhere to "one sentence per line" formatting #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmcgowan
reviewed
Jun 7, 2018
spec.md
Outdated
| ``` | ||
| digest := algorithm ":" hex | ||
| algorithm := /[A-Fa-f0-9_+.-]+/ | ||
| algorithm := /[A-Fa-f0-9_+. | ||
| -]+/ |
dmcgowan
reviewed
Jun 7, 2018
spec.md
Outdated
| All layer uploads use two steps to manage the upload process. | ||
| The first step starts the upload in the registry service, returning a url to carry out the second step. | ||
| The second step uses the upload url to transfer the actual data. | ||
| Uploads are started with a POST request which returns a url that can be usedto push data and check upload status. |
dmcgowan
reviewed
Jun 7, 2018
spec.md
Outdated
| @@ -933,48 +807,40 @@ Link: <<url>?n=<n from the request>&last=<last repository in response>>; rel="ne | |||
| { | |||
| "repositories": [ | |||
| <name>, | |||
| ... | |||
| . | |||
dmcgowan
reviewed
Jun 7, 2018
spec.md
Outdated
|
|
||
| ###### On Failure: Authentication Required | ||
|
|
||
| ``` | ||
| 401 Unauthorized | ||
| WWW-Authenticate: <scheme> realm="<realm>", ..." | ||
| WWW-Authenticate: <scheme> realm="<realm>", ... | ||
| " |
dmcgowan
reviewed
Jun 7, 2018
spec.md
Outdated
| @@ -3672,28 +3188,24 @@ Content-Type: application/json; charset=utf-8 | |||
| "detail": ... | |||
| }, | |||
| ... | |||
| ] | |||
| ] | |||
There was a problem hiding this comment.
I don't think this fomatting change is correct
dmcgowan
reviewed
Jun 7, 2018
spec.md
Outdated
| The upload is unknown to the registry. The upload must be restarted. | ||
|
|
||
|
|
||
| The upload is unknown to the registry.The upload must be restarted. |
|
Thanks for doing this, just a couple formatting corrections! Make sure to sign commit |
|
Thanks for the review and catching my mistakes! |
|
Update looks good, can you please sign the commit |
|
Oh! Did you mean |
Fixes opencontainers#4. Signed-off-by: Jimmy Zelinskie <jimmy.zelinskie+git@gmail.com>
|
LGTM |
1 similar comment
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4.
Thank god for sed and vim macros.