Skip to content

Commit

Permalink
Merge pull request #419 from rogpeppe-contrib/001-no-fail-on-no-report
Browse files Browse the repository at this point in the history
conformance: do not fail on report generation failure
  • Loading branch information
vbatts authored Jun 23, 2023
2 parents efe2de0 + caded17 commit f49a193
Showing 1 changed file with 11 additions and 4 deletions.
15 changes: 11 additions & 4 deletions conformance/reporter.go
Original file line number Diff line number Diff line change
Expand Up @@ -526,6 +526,12 @@ func (reporter *HTMLReporter) save(snapshot *specSnapshot) {
}

func (reporter *HTMLReporter) SpecSuiteDidEnd(summary *types.SuiteSummary) {
if err := reporter.writeReport(summary); err != nil {
log.Printf("WARNING: cannot write HTML summary report: %v", err)
}
}

func (reporter *HTMLReporter) writeReport(summary *types.SuiteSummary) error {
reporter.endTime = time.Now()
reporter.EndTimeString = reporter.endTime.Format("Jan 2 15:04:05.000 -0700 MST")
reporter.RunTime = reporter.endTime.Sub(reporter.startTime).String()
Expand All @@ -539,26 +545,27 @@ func (reporter *HTMLReporter) SpecSuiteDidEnd(summary *types.SuiteSummary) {

t, err := template.New("report").Parse(htmlTemplate)
if err != nil {
log.Fatal(err)
return fmt.Errorf("cannot parse report template: %v", err)
}

htmlReportFilenameAbsPath, err := filepath.Abs(reporter.htmlReportFilename)
if err != nil {
log.Fatal(err)
return err
}

htmlReportFile, err := os.Create(htmlReportFilenameAbsPath)
if err != nil {
log.Fatal(err)
return err
}
defer htmlReportFile.Close()

err = t.ExecuteTemplate(htmlReportFile, "report", &reporter)
if err != nil {
log.Fatal(err)
return err
}

fmt.Printf("HTML report was created: %s", htmlReportFilenameAbsPath)
return nil
}

//unused by HTML reporter
Expand Down

0 comments on commit f49a193

Please sign in to comment.