Skip to content

Conversation

@kolyshkin
Copy link
Contributor

@kolyshkin kolyshkin commented Mar 2, 2025

This adds some validation for PR as well as running the unit tests.

For a test run, see

Updates #2.

Taken from runc.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Taken from runc.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Also, fix a typo found in RELEASES.md.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Taken from runc.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Simpler than that in runc as we don't use vendor here.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
This is so we can mark it as required in PR merge rules.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@kolyshkin kolyshkin marked this pull request as ready for review March 2, 2025 20:34
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianon
Copy link
Member

tianon commented Mar 5, 2025

Looks like we need to clean up access on this repo (I shouldn't have a green button!)

Pinging maintainers for another review: @AkihiroSuda @cyphar @mrunalp @odinuge @haircommander @dims

Copy link

@dims dims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dims
Copy link

dims commented Mar 5, 2025

@tianon no 🟢 button for me either :)

@AkihiroSuda AkihiroSuda merged commit 03beff6 into opencontainers:main Mar 5, 2025
1 check passed
@kolyshkin kolyshkin mentioned this pull request Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants