Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unmarshal performance regression #84

Merged
merged 1 commit into from
Jan 31, 2023
Merged

Fix unmarshal performance regression #84

merged 1 commit into from
Jan 31, 2023

Conversation

DanG100
Copy link
Contributor

@DanG100 DanG100 commented Jan 31, 2023

Before this change, repeated calls the unmarshal would reuse the the root object, so for extremely large wildcard watches, so this be slow. By creating a new schema every time, the root object gets GC so it's faster and uses less memory

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4056979310

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 29 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.03%) to 83.976%

Files with Coverage Reduction New Missed Lines %
schemaless/schemaless.go 9 83.05%
ygnmi/unmarshal.go 20 62.72%
Totals Coverage Status
Change from base Build 3897863929: 0.03%
Covered Lines: 1677
Relevant Lines: 1997

💛 - Coveralls

@DanG100 DanG100 merged commit 430766e into main Jan 31, 2023
@DanG100 DanG100 deleted the unmarshal-fix branch January 31, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants