Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SetRequest shadow path unmarshaling #65

Merged
merged 1 commit into from
Oct 7, 2022
Merged

Fix SetRequest shadow path unmarshaling #65

merged 1 commit into from
Oct 7, 2022

Conversation

DanG100
Copy link
Contributor

@DanG100 DanG100 commented Oct 6, 2022

No description provided.

@DanG100 DanG100 requested a review from wenovus October 6, 2022 22:56
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3201014017

  • 15 of 15 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 88.518%
Totals Coverage Status
Change from base Build 3176866100: 0.02%
Covered Lines: 1565
Relevant Lines: 1768
💛 - Coveralls

wenovus
wenovus reviewed Oct 6, 2022
View reviewed changes
Copy link
Contributor

@wenovus wenovus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth adding a test here? else looks good.

@DanG100
Copy link
Contributor Author

DanG100 commented Oct 6, 2022

Worth adding a test here? else looks good.

I think not yet, since the generates code will never create a ConfigQuery with IsState is true. (only our lemming hack does). If/when we add custom/dynamic/schemaless queries to ygnmi I'll have tests for this behavior.

wenovus
wenovus approved these changes Oct 6, 2022
View reviewed changes
Copy link
Contributor

@wenovus wenovus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, thanks

@DanG100 DanG100 merged commit 8d22029 into main Oct 7, 2022
@DanG100 DanG100 deleted the config-shadow-path branch October 7, 2022 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenovus wenovus wenovus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DanG100 @coveralls @wenovus