Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export query interfaces method #59

Merged
merged 1 commit into from
Sep 1, 2022
Merged

Export query interfaces method #59

merged 1 commit into from
Sep 1, 2022

Conversation

DanG100
Copy link
Contributor

@DanG100 DanG100 commented Sep 1, 2022

This change allows users of the library to access some of the ygot features directly from the query type.

Given that the interface types are all "getters" it seems safe to export these funcs.

@DanG100 DanG100 requested a review from wenovus September 1, 2022 19:34
@coveralls
Copy link

coveralls commented Sep 1, 2022

Pull Request Test Coverage Report for Build 2974798536

  • 0 of 8 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 88.51%

Changes Missing Coverage Covered Lines Changed/Added Lines %
ygnmi/types.go 0 8 0.0%
Totals Coverage Status
Change from base Build 2907820575: 0.0%
Covered Lines: 1533
Relevant Lines: 1732

💛 - Coveralls

Copy link
Contributor

@wenovus wenovus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do all of the AnyQuery methods need to be exported? Or just a subset of them? I think keeping the public API small is a good idea if there is no need to export.

@DanG100
Copy link
Contributor Author

DanG100 commented Sep 1, 2022

Do all of the AnyQuery methods need to be exported? Or just a subset of them? I think keeping the public API small is a good idea if there is no need to export.

figure out a simpler way to do what i want, only need to export IsConfig() and IsSingleton, so that in lemming we can convert a state query to config query

@DanG100 DanG100 requested a review from wenovus September 1, 2022 20:41
@DanG100 DanG100 merged commit d93fc4e into main Sep 1, 2022
@DanG100 DanG100 deleted the export-query branch September 1, 2022 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants