Add per call options to ygnmi #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2892189026
💛 - Coveralls |
wenovus
reviewed
Aug 19, 2022
wenovus
approved these changes
Aug 19, 2022
greg-dennis
reviewed
Aug 22, 2022
| stub *Stubber | ||
| agent *gnmi.Agent | ||
| stub *Stubber | ||
| getWrapper *getWrapper |
There was a problem hiding this comment.
I know this was the Ondatra naming, but maybe "clientWrapper" would be a better name, since it wraps the client? Or perhaps the field could be named "clientWrapper" and the struct named "clientWithGetter"
| getRequests []*gpb.GetRequest | ||
| } | ||
|
|
||
| // Get is fake implement of gnmi.Get, it returns the GetResponse contained in the stub. |
There was a problem hiding this comment.
"is fake implement" -> "is a fake implementation"?
| @@ -87,6 +116,12 @@ func (s *Stubber) Notification(n *gpb.Notification) *Stubber { | |||
| return s | |||
| } | |||
|
|
|||
| // AppendGetResponse appends the given GetResponse as a stub response. | |||
| func (s *Stubber) AppendGetResponse(gr *gpb.GetResponse) *Stubber { | |||
There was a problem hiding this comment.
All the other methods on Stubber are named by what they stub/append and omit the word "append". Justification for this one breaking that pattern?
| return nil | ||
| } | ||
|
|
||
| // Recv returns the result of the Get request, returning io.EOF after resonpse are read. |
|
fixes in #58 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.