Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flag changes #54

Merged
merged 4 commits into from
Jun 21, 2022
Merged

Flag changes #54

merged 4 commits into from
Jun 21, 2022

Conversation

DanG100
Copy link
Contributor

@DanG100 DanG100 commented Jun 17, 2022

  • schema_struct_path is hidden
  • base_import_path -> base_package_path
  • Add trim_prefix -> control enum prefixes and package prefixes

rootPackageName -> is now the last elem of base_import_path + "path"

@coveralls
Copy link

coveralls commented Jun 17, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2536931055

  • 14 of 14 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 88.337%
Totals Coverage Status
Change from base Build 2518167917: 0.0%
Covered Lines: 1477
Relevant Lines: 1672
💛 - Coveralls

@DanG100 DanG100 requested review from wenovus and greg-dennis and removed request for wenovus June 17, 2022 22:43
wenovus
wenovus reviewed Jun 18, 2022
View reviewed changes
Copy link
Contributor

@wenovus wenovus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks this looks good, had a few comments.

app/ygnmi/cmd/generator/generator.go Outdated Show resolved Hide resolved
app/ygnmi/cmd/generator/generator.go Outdated Show resolved Hide resolved
pathgen/pathgen.go Outdated Show resolved Hide resolved
greg-dennis
greg-dennis approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@greg-dennis greg-dennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending consensus on the trim_prefix name

app/ygnmi/cmd/generator/generator.go Outdated Show resolved Hide resolved
@DanG100 DanG100 merged commit 916ff90 into main Jun 21, 2022
@DanG100 DanG100 deleted the flag-changes branch June 21, 2022 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenovus wenovus wenovus left review comments

@greg-dennis greg-dennis greg-dennis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DanG100 @coveralls @greg-dennis @wenovus