Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simply list generation #53

Merged
merged 3 commits into from
Jun 17, 2022
Merged

Simply list generation #53

merged 3 commits into from
Jun 17, 2022

Conversation

DanG100
Copy link
Contributor

@DanG100 DanG100 commented Jun 17, 2022

  • Always generate fully keyed list
  • Always generates builder API
  • Remove ListBuilderThreshold and SimplifyWildcard paths as they are no longer needed

@DanG100 DanG100 requested review from greg-dennis and wenovus and removed request for greg-dennis June 17, 2022 19:15
@coveralls
Copy link

coveralls commented Jun 17, 2022

Pull Request Test Coverage Report for Build 2517839743

  • 29 of 33 (87.88%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.5%) to 88.337%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pathgen/pathgen.go 29 33 87.88%
Totals Coverage Status
Change from base Build 2505800705: -0.5%
Covered Lines: 1477
Relevant Lines: 1672

💛 - Coveralls

pathgen/pathgen_test.go Show resolved Hide resolved
pathgen/pathgen.go Outdated Show resolved Hide resolved
pathgen/pathgen.go Outdated Show resolved Hide resolved
@DanG100 DanG100 merged commit d330fcb into main Jun 17, 2022
@DanG100 DanG100 deleted the list-simple branch June 17, 2022 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants