Skip to content

Conversation

@sumedhak27
Copy link

Change Scope

  • DHCPv6 advertise message is spelled incorrectly; correct it.
  • The change won't be backward compatible, i.e., the incorrectly
    spelled leaf won't be available further.

DHCPv6 advertise message is spelled incorrectly; correct it.
@google-cla
Copy link

google-cla bot commented Aug 5, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@dplore
Copy link
Member

dplore commented Aug 7, 2025

/gcbrun

@dplore dplore requested a review from a team as a code owner August 7, 2025 02:15
@dplore
Copy link
Member

dplore commented Aug 7, 2025

/gcbrun

@OpenConfigBot
Copy link

OpenConfigBot commented Aug 7, 2025

No major YANG version changes in commit 3e4ebd2

@ghananigans ghananigans self-assigned this Aug 21, 2025
@ghananigans
Copy link

Per OC guidance,

That is, with major version 0, there should be no expectation of compatibility from one release to another, even if only the minor version number is changing.

Backwards-incompatibility LGTM given the above.

@dplore
Copy link
Member

dplore commented Aug 21, 2025

/gcbrun

@dplore dplore moved this to In Progress in OC Operator Review Aug 21, 2025
@dplore dplore moved this from In Progress to Ready to discuss in OC Operator Review Aug 21, 2025
Copy link
Member

@dplore dplore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Module version number needs to be updated (to 0.2.0)

@ElodinLaarz
Copy link
Contributor

Discussed at OC Operators Meeting Oct 07:

Fixing a typo in major version 0 seems reasonable. Moving to last-call for 2 weeks from now.

@ElodinLaarz ElodinLaarz moved this from Ready to discuss to last-call in OC Operator Review Oct 7, 2025
@ElodinLaarz
Copy link
Contributor

/gcbrun

@ElodinLaarz
Copy link
Contributor

Module version number needs to be updated (to 0.2.0)

Seems like we still have to do this?

@ElodinLaarz
Copy link
Contributor

Discussed at the OC Operators Meeting on October 28th:

Since the model is actually 9 years old, then it's actually possible that this is a "breaking" change, even though the version is still 0, as someone could have implemented it and started using it.

Our recommendation here is to make this a non-breaking change by deprecating the old-spelling and then adding the new leaf with the proper spelling.

@ElodinLaarz ElodinLaarz moved this from last-call to Waiting for author in OC Operator Review Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Waiting for author

Development

Successfully merging this pull request may close these issues.

5 participants