Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACL bug fixes + update to Go 1.23 #492

Merged
merged 5 commits into from
Oct 30, 2024
Merged

ACL bug fixes + update to Go 1.23 #492

merged 5 commits into from
Oct 30, 2024

Conversation

DanG100
Copy link
Collaborator

@DanG100 DanG100 commented Oct 30, 2024

No description provided.

@DanG100 DanG100 changed the title ACL bug fixes + update + 1.23 ACL bug fixes + update to Go 1.23 Oct 30, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 30, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11603173833

Details

  • 19 of 23 (82.61%) changed or added relevant lines in 2 files are covered.
  • 8 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.009%) to 2.886%
Changes Missing Coverage Covered Lines Changed/Added Lines %
dataplane/saiserver/acl.go 18 22 81.82%
Files with Coverage Reduction New Missed Lines %
dataplane/kernel/kerneltest/kernel.go 8 72.6%
Totals Coverage Status
Change from base Build 11563833838: 0.009%
Covered Lines: 19007
Relevant Lines: 658695
💛 - Coveralls

guoshiuan
guoshiuan approved these changes Oct 30, 2024
View reviewed changes
dataplane/saiserver/acl.go Outdated Show resolved Hide resolved
@DanG100 DanG100 merged commit 6a07d7b into main Oct 30, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guoshiuan guoshiuan guoshiuan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanG100 @guoshiuan