Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add l2 advertisment to metallb add clientset and tests #211

Merged
merged 2 commits into from
Sep 14, 2022
Merged

Conversation

marcushines
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Sep 14, 2022

Pull Request Test Coverage Report for Build 3054150569

  • 115 of 153 (75.16%) changed or added relevant lines in 4 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.3%) to 59.47%

Changes Missing Coverage Covered Lines Changed/Added Lines %
deploy/deploy.go 10 13 76.92%
api/metallb/clientset/v1beta1/client.go 9 16 56.25%
api/metallb/clientset/v1beta1/ipaddresspool.go 48 62 77.42%
api/metallb/clientset/v1beta1/l2advertisement.go 48 62 77.42%
Files with Coverage Reduction New Missed Lines %
api/metallb/clientset/v1beta1/client.go 2 63.04%
Totals Coverage Status
Change from base Build 3045602664: 0.3%
Covered Lines: 2355
Relevant Lines: 3960

💛 - Coveralls

@marcushines
Copy link
Contributor Author

marcushines commented Sep 14, 2022

Validated this with 3node-withtraffic

hines@hines-1:~/go/src/github.com/openconfig/kne$ ssh admin@192.168.16.55
Warning: Permanently added '192.168.16.55' (ED25519) to the list of known hosts.
(admin@192.168.16.55) Password:
Last login: Wed Sep 14 15:27:23 2022 from 10.244.0.1
r1#show ver
Arista cEOSLab
Hardware version:
Serial number:
Hardware MAC address: 0e6e.fd5e.ed77
System MAC address: 0e6e.fd5e.ed77

cEOS tools version: 1.1
Kernel version: 5.17.11-1rodete2-amd64

Uptime: 19 minutes
Total memory: 185667384 kB
Free memory: 153913248 kB

r1#

@marcushines marcushines merged commit 81cebfa into main Sep 14, 2022
@marcushines marcushines deleted the hines branch September 14, 2022 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants