Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add README for IPv6 ND suppression. #3262

Merged
merged 2 commits into from
Jul 16, 2024
Merged

Conversation

sugrimov
Copy link
Contributor

No description provided.

@sugrimov sugrimov requested review from a team as code owners July 12, 2024 16:50
@OpenConfigBot
Copy link

OpenConfigBot commented Jul 12, 2024

Pull Request Functional Test Report for #3262 / b27dccd

No tests identified for validation.

Help

@coveralls
Copy link

coveralls commented Jul 12, 2024

Pull Request Test Coverage Report for Build 9941694594

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.5%

Totals Coverage Status
Change from base Build 9902708584: 0.0%
Covered Lines: 1983
Relevant Lines: 3573

💛 - Coveralls

dplore
dplore previously approved these changes Jul 13, 2024
Copy link
Member

@dplore dplore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of nits and one question, but LGTM.

## Procedure
* Connect DUT port-1 to OTG port-1
* Configure IPv6 address on DUT port-1
* Set IPv6 ND RA transmission interval on DUT port-1 to 5 seconds
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems ok, but is there a purpose to setting this? Just to see if it exists and that suppress overrides it?

* Set IPv6 ND RA transmission interval on DUT port-1 to 5 seconds
* Enable IPv6 ND RA suppression on DUT port-1

### TestCase-1: No periodical Router Advertisement are sent
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:

Suggested change
### TestCase-1: No periodical Router Advertisement are sent
### RT-5.11.1: No periodical Router Advertisement are sent


* Verify over period of 10 seconds that IPv6 ND RA **doesn't** arrives on OTG Port-1 ([rfc4861 section 6.2.1](https://datatracker.ietf.org/doc/html/rfc4861#section-6.2.1))

### TestCase-2: Router Advertisement response is sent to Router Solicitation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### TestCase-2: Router Advertisement response is sent to Router Solicitation
### RT-5.11.2: Router Advertisement response is sent to Router Solicitation

@dplore dplore merged commit e0e6166 into openconfig:main Jul 16, 2024
13 checks passed
frasieroh pushed a commit to aristanetworks/openconfig-featureprofiles that referenced this pull request Jul 16, 2024
* Add README for IPv6 ND suppression.
bkreddy143 pushed a commit to nokia/featureprofiles that referenced this pull request Jul 17, 2024
* Add README for IPv6 ND suppression.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

5 participants