Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gNMI-1.4 to validate subcomponents paths. #3132

Merged
merged 10 commits into from
Jun 26, 2024
Merged

Update gNMI-1.4 to validate subcomponents paths. #3132

merged 10 commits into from
Jun 26, 2024

Conversation

SydneyCaulfeild
Copy link
Contributor

@SydneyCaulfeild SydneyCaulfeild commented Jun 25, 2024 •
edited
Loading

If a component has either components/component/subcomponents/subcomponent/name or components/component/subcomponents/subcomponent/state/name, then the leafref value of this path should be for a component that exists on that device.

@OpenConfigBot
Copy link

OpenConfigBot commented Jun 25, 2024 •
edited
Loading

Pull Request Functional Test Report for #3132 / c1b2266

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
 gNMI-1.4: Telemetry: Inventory
Cisco 8000E status
 gNMI-1.4: Telemetry: Inventory
Cisco XRd status
 gNMI-1.4: Telemetry: Inventory
Juniper ncPTX status
 gNMI-1.4: Telemetry: Inventory
Nokia SR Linux status
 gNMI-1.4: Telemetry: Inventory
Openconfig Lemming status
 gNMI-1.4: Telemetry: Inventory

Hardware Devices

Device Test Test Documentation Raw Log
Arista 7808 status
 gNMI-1.4: Telemetry: Inventory
Cisco 8808 status
 gNMI-1.4: Telemetry: Inventory
Juniper PTX10008 status
 gNMI-1.4: Telemetry: Inventory
Nokia 7250 IXR-10e status
 gNMI-1.4: Telemetry: Inventory

Help

@coveralls
Copy link

coveralls commented Jun 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9668043105

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.5%
Totals Coverage Status
Change from base Build 9666591456: 0.0%
Covered Lines: 1983
Relevant Lines: 3573
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9669177838

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.5%
Totals Coverage Status
Change from base Build 9666591456: 0.0%
Covered Lines: 1983
Relevant Lines: 3573
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9669364830

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.5%
Totals Coverage Status
Change from base Build 9666591456: 0.0%
Covered Lines: 1983
Relevant Lines: 3573
💛 - Coveralls

@SydneyCaulfeild SydneyCaulfeild marked this pull request as ready for review June 25, 2024 21:15
@SydneyCaulfeild SydneyCaulfeild requested review from a team as code owners June 25, 2024 21:15
@coveralls
Copy link

coveralls commented Jun 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9669707699

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.5%
Totals Coverage Status
Change from base Build 9669496273: 0.0%
Covered Lines: 1983
Relevant Lines: 3573
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9670920467

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.5%
Totals Coverage Status
Change from base Build 9670465998: 0.0%
Covered Lines: 1983
Relevant Lines: 3573
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 9670926348

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.5%
Totals Coverage Status
Change from base Build 9670465998: 0.0%
Covered Lines: 1983
Relevant Lines: 3573
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9670939927

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.5%
Totals Coverage Status
Change from base Build 9670465998: 0.0%
Covered Lines: 1983
Relevant Lines: 3573
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9670972619

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.5%
Totals Coverage Status
Change from base Build 9670465998: 0.0%
Covered Lines: 1983
Relevant Lines: 3573
💛 - Coveralls

@SydneyCaulfeild SydneyCaulfeild marked this pull request as draft June 25, 2024 23:35
wenovus
wenovus previously approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@wenovus wenovus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One optional comment.

feature/platform/tests/telemetry_inventory_test/telemetry_inventory_test.go Outdated Show resolved Hide resolved
@SydneyCaulfeild SydneyCaulfeild marked this pull request as ready for review June 25, 2024 23:41
wenovus
wenovus previously approved these changes Jun 25, 2024
View reviewed changes
@coveralls
Copy link

coveralls commented Jun 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9671095556

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.5%
Totals Coverage Status
Change from base Build 9670465998: 0.0%
Covered Lines: 1983
Relevant Lines: 3573
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9671122211

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.5%
Totals Coverage Status
Change from base Build 9670465998: 0.0%
Covered Lines: 1983
Relevant Lines: 3573
💛 - Coveralls

@wenovus wenovus merged commit 8fa624a into openconfig:main Jun 26, 2024
13 checks passed
frasieroh pushed a commit to aristanetworks/openconfig-featureprofiles that referenced this pull request Jun 26, 2024
@SydneyCaulfeild @frasieroh
Update gNMI-1.4 to validate subcomponents paths. (openconfig#3132)
d8f480f 
* Add subcomponents/ to README.

* Check that subcomponent exists in telemetry_inventory_test.

* Update README - validate sucomponent name for any component type.

* Fix iteration over subcomponents.

* Rename variable.

* Add else for empty subcomponent.

* Access subcomponent directly.

* Rename function and update comment
nsadhasivam pushed a commit to nsadhasivam/featureprofiles that referenced this pull request Jun 27, 2024
@SydneyCaulfeild @nsadhasivam
Update gNMI-1.4 to validate subcomponents paths. (openconfig#3132)
becc4d0 
* Add subcomponents/ to README.

* Check that subcomponent exists in telemetry_inventory_test.

* Update README - validate sucomponent name for any component type.

* Fix iteration over subcomponents.

* Rename variable.

* Add else for empty subcomponent.

* Access subcomponent directly.

* Rename function and update comment
ANISH-GOTTAPU pushed a commit to open-traffic-generator/featureprofiles that referenced this pull request Jul 10, 2024
@SydneyCaulfeild @ANISH-GOTTAPU
Update gNMI-1.4 to validate subcomponents paths. (openconfig#3132)
44d3e21 
* Add subcomponents/ to README.

* Check that subcomponent exists in telemetry_inventory_test.

* Update README - validate sucomponent name for any component type.

* Fix iteration over subcomponents.

* Rename variable.

* Add else for empty subcomponent.

* Access subcomponent directly.

* Rename function and update comment
bkreddy143 pushed a commit to nokia/featureprofiles that referenced this pull request Jul 17, 2024
@SydneyCaulfeild @bkreddy143
Update gNMI-1.4 to validate subcomponents paths. (openconfig#3132)
8242400 
* Add subcomponents/ to README.

* Check that subcomponent exists in telemetry_inventory_test.

* Update README - validate sucomponent name for any component type.

* Fix iteration over subcomponents.

* Rename variable.

* Add else for empty subcomponent.

* Access subcomponent directly.

* Rename function and update comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenovus wenovus wenovus approved these changes

Assignees

@dplore dplore

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SydneyCaulfeild @OpenConfigBot @coveralls @wenovus @dplore