Create README for MTU-1.5 PMTUD handling. #3067

sugrimov · 2024-06-10T17:02:26Z

No description provided.

coveralls · 2024-06-10T17:10:00Z

Pull Request Test Coverage Report for Build 9452525653

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 55.5%

Totals
Change from base Build 9451206995:	0.0%
Covered Lines:	1983
Relevant Lines:	3573

💛 - Coveralls

coveralls · 2024-06-10T17:23:42Z

Pull Request Test Coverage Report for Build 9452712295

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 55.5%

Totals
Change from base Build 9451206995:	0.0%
Covered Lines:	1983
Relevant Lines:	3573

💛 - Coveralls

feature/mtu/otg_tests/pmtu_handing/README.md

coveralls · 2024-06-11T11:18:03Z

Pull Request Test Coverage Report for Build 9464534153

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 55.5%

Totals
Change from base Build 9451206995:	0.0%
Covered Lines:	1983
Relevant Lines:	3573

💛 - Coveralls

coveralls · 2024-06-11T11:26:31Z

Pull Request Test Coverage Report for Build 9464600245

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 55.5%

Totals
Change from base Build 9451206995:	0.0%
Covered Lines:	1983
Relevant Lines:	3573

💛 - Coveralls

coveralls · 2024-06-11T11:31:42Z

Pull Request Test Coverage Report for Build 9464710453

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 55.5%

Totals
Change from base Build 9460352009:	0.0%
Covered Lines:	1983
Relevant Lines:	3573

💛 - Coveralls

coveralls · 2024-06-11T11:31:42Z

Pull Request Test Coverage Report for Build 9464714738

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 55.5%

Totals
Change from base Build 9460352009:	0.0%
Covered Lines:	1983
Relevant Lines:	3573

💛 - Coveralls

dplore

Please add the packet-processing-aggregate and control-plane-traffic counters, otherwise LGTM

coveralls · 2024-06-12T11:16:13Z

Pull Request Test Coverage Report for Build 9481482302

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 55.5%

Totals
Change from base Build 9460352009:	0.0%
Covered Lines:	1983
Relevant Lines:	3573

💛 - Coveralls

coveralls · 2024-06-12T11:23:33Z

Pull Request Test Coverage Report for Build 9481576034

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 55.5%

Totals
Change from base Build 9480186645:	0.0%
Covered Lines:	1983
Relevant Lines:	3573

💛 - Coveralls

coveralls · 2024-06-12T11:47:20Z

Pull Request Test Coverage Report for Build 9481899893

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 55.5%

Totals
Change from base Build 9480186645:	0.0%
Covered Lines:	1983
Relevant Lines:	3573

💛 - Coveralls

feature/mtu/otg_tests/pmtu_handing/README.md

Co-authored-by: Darren Loher <dloher@google.com>

OpenConfigBot · 2024-07-17T10:25:34Z

Pull Request Functional Test Report for #3067 / `38baf8c`

No tests identified for validation.

Help

coveralls · 2024-07-17T10:32:46Z

Pull Request Test Coverage Report for Build 10039853246

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 55.5%

Totals
Change from base Build 9968056050:	0.0%
Covered Lines:	1983
Relevant Lines:	3573

💛 - Coveralls

dplore · 2024-07-17T19:21:00Z

feature/mtu/otg_tests/pmtu_handing/README.md

+      platform_type: [ "INTEGRATED_CIRCUIT" ]
+    /components/component/integrated-circuit/pipeline-counters/drop/lookup-block/state/fragment-total-drops:
+      platform_type: [ "INTEGRATED_CIRCUIT" ]
+    /components/component/integrated-circuit/pipeline-counters/control-plane-traffic/vendor:


Thanks for adding this path I asked for! Unfortunately our CI check for paths only allows leaf paths and not containers like this.

Since we don't know what the leaf path(s) for this will be. So please move this path out of this yaml section and into the main body with some text like:

The device may support some vendor proprietary leafs to count MTU exceeded packets which are dropped due to control plane policing rules in the `components/component/integrated-circuit/pipeline-counters/control-plane-traffic/vendor` tree. Implementation should add code with a switch statement to expose these counters, if they exist.

* Create README for MTU-1.5 PMTUD handling. --------- Co-authored-by: Darren Loher <dloher@google.com>

Create README for MTU-1.5 PMTUD handling.

48cc736

sugrimov requested review from a team as code owners June 10, 2024 17:02

Create README for MTU-1.5 PMTUD handling.

691d2a0

dplore reviewed Jun 11, 2024

View reviewed changes

Augment MTU-1.5 test

f0830dc

Update paths MTU-1.5

0a40f37

sugrimov added 2 commits June 11, 2024 11:27

Update paths MTU-1.5

9b3eb56

Merge branch 'main' into sugrimov-mtu15

be1f746

sugrimov assigned dplore Jun 11, 2024

dplore reviewed Jun 12, 2024

View reviewed changes

sugrimov added 2 commits June 12, 2024 11:07

Add clarifications to MTU-1.5

9ca1caf

Merge branch 'main' into sugrimov-mtu15

2f248e8

Update paths in MTU-1.5

8725628

dplore approved these changes Jul 16, 2024

View reviewed changes

dplore requested changes Jul 16, 2024

View reviewed changes

feature/mtu/otg_tests/pmtu_handing/README.md Outdated Show resolved Hide resolved

sugrimov and others added 2 commits July 17, 2024 11:25

Update feature/mtu/otg_tests/pmtu_handing/README.md

210ce5c

Co-authored-by: Darren Loher <dloher@google.com>

Merge branch 'main' into sugrimov-mtu15

2ba714f

Update README.md

b9c60e5

dplore previously approved these changes Jul 17, 2024

View reviewed changes

dplore reviewed Jul 17, 2024

View reviewed changes

Update README.md

38baf8c

sugrimov dismissed dplore’s stale review via 38baf8c July 22, 2024 11:21

dplore approved these changes Jul 24, 2024

View reviewed changes

dplore merged commit 50246ee into openconfig:main Jul 24, 2024
13 checks passed

frasieroh pushed a commit to aristanetworks/openconfig-featureprofiles that referenced this pull request Jul 25, 2024

Create README for MTU-1.5 PMTUD handling. (openconfig#3067)

3474e75

* Create README for MTU-1.5 PMTUD handling. --------- Co-authored-by: Darren Loher <dloher@google.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create README for MTU-1.5 PMTUD handling. #3067

Create README for MTU-1.5 PMTUD handling. #3067

sugrimov commented Jun 10, 2024

coveralls commented Jun 10, 2024 •

edited

Loading

coveralls commented Jun 10, 2024 •

edited

Loading

coveralls commented Jun 11, 2024 •

edited

Loading

coveralls commented Jun 11, 2024 •

edited

Loading

coveralls commented Jun 11, 2024 •

edited

Loading

coveralls commented Jun 11, 2024 •

edited

Loading

dplore left a comment

coveralls commented Jun 12, 2024 •

edited

Loading

coveralls commented Jun 12, 2024 •

edited

Loading

coveralls commented Jun 12, 2024 •

edited

Loading

OpenConfigBot commented Jul 17, 2024 •

edited

Loading

coveralls commented Jul 17, 2024 •

edited

Loading

dplore Jul 17, 2024

Create README for MTU-1.5 PMTUD handling. #3067

Create README for MTU-1.5 PMTUD handling. #3067

Conversation

sugrimov commented Jun 10, 2024

coveralls commented Jun 10, 2024 • edited Loading

Pull Request Test Coverage Report for Build 9452525653

Details

💛 - Coveralls

coveralls commented Jun 10, 2024 • edited Loading

Pull Request Test Coverage Report for Build 9452712295

Warning: This coverage report may be inaccurate.

Details

💛 - Coveralls

coveralls commented Jun 11, 2024 • edited Loading

Pull Request Test Coverage Report for Build 9464534153

Warning: This coverage report may be inaccurate.

Details

💛 - Coveralls

coveralls commented Jun 11, 2024 • edited Loading

Pull Request Test Coverage Report for Build 9464600245

Warning: This coverage report may be inaccurate.

Details

💛 - Coveralls

coveralls commented Jun 11, 2024 • edited Loading

Pull Request Test Coverage Report for Build 9464710453

Details

💛 - Coveralls

coveralls commented Jun 11, 2024 • edited Loading

Pull Request Test Coverage Report for Build 9464714738

Details

💛 - Coveralls

dplore left a comment

Choose a reason for hiding this comment

coveralls commented Jun 12, 2024 • edited Loading

Pull Request Test Coverage Report for Build 9481482302

Warning: This coverage report may be inaccurate.

Details

💛 - Coveralls

coveralls commented Jun 12, 2024 • edited Loading

Pull Request Test Coverage Report for Build 9481576034

Details

💛 - Coveralls

coveralls commented Jun 12, 2024 • edited Loading

Pull Request Test Coverage Report for Build 9481899893

Details

💛 - Coveralls

OpenConfigBot commented Jul 17, 2024 • edited Loading

Pull Request Functional Test Report for #3067 / 38baf8c

coveralls commented Jul 17, 2024 • edited Loading

Pull Request Test Coverage Report for Build 10039853246

Warning: This coverage report may be inaccurate.

Details

💛 - Coveralls

dplore Jul 17, 2024

Choose a reason for hiding this comment

coveralls commented Jun 10, 2024 •

edited

Loading

coveralls commented Jun 10, 2024 •

edited

Loading

coveralls commented Jun 11, 2024 •

edited

Loading

coveralls commented Jun 11, 2024 •

edited

Loading

coveralls commented Jun 11, 2024 •

edited

Loading

coveralls commented Jun 11, 2024 •

edited

Loading

coveralls commented Jun 12, 2024 •

edited

Loading

coveralls commented Jun 12, 2024 •

edited

Loading

coveralls commented Jun 12, 2024 •

edited

Loading

OpenConfigBot commented Jul 17, 2024 •

edited

Loading

Pull Request Functional Test Report for #3067 / `38baf8c`

coveralls commented Jul 17, 2024 •

edited

Loading