-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validation Script for OC Path and RPC Coverage in READMEs #2865
Commits on Mar 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 6632935 - Browse repository at this point
Copy the full SHA 6632935View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7329e95 - Browse repository at this point
Copy the full SHA 7329e95View commit details -
Configuration menu - View commit details
-
Copy full SHA for e5a0e45 - Browse repository at this point
Copy the full SHA e5a0e45View commit details
Commits on Mar 30, 2024
-
Validation Script for OC Path and RPC Coverage in READMEs
* `mdocspec` package parses ocpath.proto and ocrpcs.proto from yaml according to the format shown below by mdocspec.Parse's documentation. * `tools/validate_readme_spec/validate_readme_spec.go` script is added that can parse and then validate OC Paths and RPCs according to existing repo states in github.com/openconfig. ```go // Parse extracts sorted OpenConfig Path and RPC Coverage from an FNT README. // // The first yaml code block after a heading line named exactly as // "OpenConfig Path and RPC Coverage" will be used. Any other code blocks are // ignored. // // Expected markdown format: // // ## OpenConfig Path and RPC Coverage // // ```yaml // paths: // /interfaces/interface/config/description: // /interfaces/interface/config/enabled: // /components/component/state/name: // platform_type: "CHASSIS" // // rpcs: // gnmi: // gNMI.Set: // union_replace: true // gNMI.Subscribe: // on_change: true // ``` // // Note: For `rpcs`, only the RPC name and methods are validated. Any // attributes defined below RPC methods (e.g. union_replace) are not validated. ```
Configuration menu - View commit details
-
Copy full SHA for 9f57dbc - Browse repository at this point
Copy the full SHA 9f57dbcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2515f36 - Browse repository at this point
Copy the full SHA 2515f36View commit details -
Configuration menu - View commit details
-
Copy full SHA for 890d3f2 - Browse repository at this point
Copy the full SHA 890d3f2View commit details
Commits on Apr 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 93bc9bd - Browse repository at this point
Copy the full SHA 93bc9bdView commit details
Commits on Apr 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5ee1b4c - Browse repository at this point
Copy the full SHA 5ee1b4cView commit details
Commits on Apr 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d6e80be - Browse repository at this point
Copy the full SHA d6e80beView commit details -
Update tools/internal/mdocspec/ocspec.go
Co-authored-by: Darren Loher <dloher@google.com>
Configuration menu - View commit details
-
Copy full SHA for 04b2b0c - Browse repository at this point
Copy the full SHA 04b2b0cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 18658b9 - Browse repository at this point
Copy the full SHA 18658b9View commit details -
Minor improvements for OC coverage validation
* Skip repo-cloning during validation if repo already cloned. * Validate that at least one RPC method is specified for any coverage spec. * Add additional validation for script in bash file. * Style Improvements.
Configuration menu - View commit details
-
Copy full SHA for 08f5448 - Browse repository at this point
Copy the full SHA 08f5448View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5826fd9 - Browse repository at this point
Copy the full SHA 5826fd9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9a1ffc5 - Browse repository at this point
Copy the full SHA 9a1ffc5View commit details -
Configuration menu - View commit details
-
Copy full SHA for b0515e0 - Browse repository at this point
Copy the full SHA b0515e0View commit details
Commits on Apr 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 218ea66 - Browse repository at this point
Copy the full SHA 218ea66View commit details
Commits on Apr 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 73d317c - Browse repository at this point
Copy the full SHA 73d317cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1f5be99 - Browse repository at this point
Copy the full SHA 1f5be99View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b79d7b - Browse repository at this point
Copy the full SHA 2b79d7bView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.