TE-15.1: Adding flag to skip ipv6 compliance cases #2522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on discussion in b/318469590 making following changes -
1. Adding skip_ipv6 flag to skip recently added ipv6 tests in gribigo compliance library.
2. Updating gribigo package version in go.mod
"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
Pull Request Functional Test Report for #2522 / 105de59Virtual Devices
Hardware Devices
|
|
@greg-dennis, can you please help to solve the static analysis issue here? It doesn't seem to be directly related to the changes in this PR, we're only bumping gribigo version in go.mod Perhaps caused by a new revive release published earlier today? |
yep the static check error is from an upstream repo: mgechev/revive#956 (comment) |
Pull Request Test Coverage Report for Build 7426009240
💛 - Coveralls |
|
@NishaSadhasivam-work static check issue was resolved thanks! |
frasieroh
pushed a commit
to aristanetworks/openconfig-featureprofiles
that referenced
this pull request
Jan 8, 2024
Based on discussion in b/318469590 making following changes -
1. Adding skip_ipv6 flag to skip recently added ipv6 tests in gribigo compliance library.
2. Updating gribigo package version in go.mod
"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
Co-authored-by: Sergey Fomin <sergey.fomin@nokia.com>
singh-prem
pushed a commit
to b4firex/featureprofiles
that referenced
this pull request
Jan 12, 2024
Based on discussion in b/318469590 making following changes -
1. Adding skip_ipv6 flag to skip recently added ipv6 tests in gribigo compliance library.
2. Updating gribigo package version in go.mod
"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
Co-authored-by: Sergey Fomin <sergey.fomin@nokia.com>
fixed merged conflict
bkreddy143
pushed a commit
to nokia/featureprofiles
that referenced
this pull request
Jul 17, 2024
Based on discussion in b/318469590 making following changes -
1. Adding skip_ipv6 flag to skip recently added ipv6 tests in gribigo compliance library.
2. Updating gribigo package version in go.mod
"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
Co-authored-by: Sergey Fomin <sergey.fomin@nokia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on discussion in b/318469590 making following changes -
1. Adding
skip_ipv6flag to skip recently added ipv6 tests in gribigo compliance library.2. Updating
gribigopackage version ingo.mod"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."