-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update go version from 1.19 to 1.21 #2270
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Functional Test Report for #2270 / c0f57fcVirtual Devices
Hardware Devices
|
just delete the call to |
Pull Request Test Coverage Report for Build 6607106635
💛 - Coveralls |
greg-dennis
previously approved these changes
Oct 23, 2023
greg-dennis
approved these changes
Oct 23, 2023
frasieroh
pushed a commit
to aristanetworks/openconfig-featureprofiles
that referenced
this pull request
Oct 24, 2023
* update go version from 1.19 to 1.21 * update seed which is deprecated * removing call to random seed * Free up space for staticcheck (openconfig#2279) --------- Co-authored-by: Brandon Stoll <bstoll@users.noreply.github.com>
frasieroh
pushed a commit
to aristanetworks/openconfig-featureprofiles
that referenced
this pull request
Oct 30, 2023
* update go version from 1.19 to 1.21 * update seed which is deprecated * removing call to random seed * Free up space for staticcheck (openconfig#2279) --------- Co-authored-by: Brandon Stoll <bstoll@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go version 1.21 has some improved Go generics inference that we want to take advantage of, hence updating the version to 1.21.