Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go version from 1.19 to 1.21 #2270

Merged
merged 9 commits into from
Oct 24, 2023
Merged

Update go version from 1.19 to 1.21 #2270

merged 9 commits into from
Oct 24, 2023

Conversation

prinikasn
Copy link
Contributor

@prinikasn prinikasn commented Oct 19, 2023

Go version 1.21 has some improved Go generics inference that we want to take advantage of, hence updating the version to 1.21.

@OpenConfigBot
Copy link

OpenConfigBot commented Oct 19, 2023

@greg-dennis
Copy link
Contributor

just delete the call to rand.Seed in setup_test.go. It's no longer needed.

@prinikasn prinikasn marked this pull request as ready for review October 20, 2023 04:43
@prinikasn prinikasn requested review from a team as code owners October 20, 2023 04:43
@github-actions
Copy link

github-actions bot commented Oct 20, 2023

Pull Request Test Coverage Report for Build 6607106635

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 46.333%

Totals Coverage Status
Change from base Build 6595484622: 0.0%
Covered Lines: 1409
Relevant Lines: 3041

💛 - Coveralls

greg-dennis
greg-dennis previously approved these changes Oct 23, 2023
@prinikasn prinikasn merged commit 75fbbb0 into main Oct 24, 2023
12 checks passed
frasieroh pushed a commit to aristanetworks/openconfig-featureprofiles that referenced this pull request Oct 24, 2023
* update go version from 1.19 to 1.21

* update seed which is deprecated

* removing call to random seed

* Free up space for staticcheck (openconfig#2279)

---------

Co-authored-by: Brandon Stoll <bstoll@users.noreply.github.com>
frasieroh pushed a commit to aristanetworks/openconfig-featureprofiles that referenced this pull request Oct 30, 2023
* update go version from 1.19 to 1.21

* update seed which is deprecated

* removing call to random seed

* Free up space for staticcheck (openconfig#2279)

---------

Co-authored-by: Brandon Stoll <bstoll@users.noreply.github.com>
@dplore dplore deleted the go_version_update branch September 10, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants