-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix P4Runtime performance test in EOS #1881
Open
prakashbadri-arista
wants to merge
9
commits into
openconfig:main
Choose a base branch
from
prakashbadri-arista:p4rt_perf_test
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix P4Runtime performance test in EOS #1881
prakashbadri-arista
wants to merge
9
commits into
openconfig:main
from
prakashbadri-arista:p4rt_perf_test
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test was failing for the following reasons: - parent interface was not routed causing the subinterfaces to not be routed as well. - DUT egress interface ip address was getting configured before the VRF assignment. So when the interface was moved to VRF-10, the interface ipv4 address got reset. - Unsupported interface ref leaf was set in the interface OC configuration - The match source ip in the vrf selection policy rule was incorrectly set and hence the incoming traffic flows expected to pass through VRF-10 were not getting forwarded correctly After fixing the above issues the test is passing correctly
…into prakashbadri-arista-fix
The test was failing intermittently in EOS because the ATE ingress counters check for verifying the expected packetOut counters was done right after injecting the traceroute/LLDP/GDP packets with no delay. There is no guarantee that all the packetOut requests have been guaranteed by that time. Added a 30s delay, to account for any trailing inflight packets.
Pull Request Functional Test Report for #1881 / ed382c2Virtual Devices
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test was failing intermittently in EOS because the ATE ingress
counters check for verifying the expected packetOut counters was done
right after injecting the traceroute/LLDP/GDP packets with no delay.
There is no guarantee that all the packetOut requests have been
guaranteed by that time. Added a 30s delay, to account for any trailing
inflight packets.