RT-1.15: BGP Add Path (Scale) #1783
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary This test checks for DUT functionality of BGP addpath capability. It also confirms accuracy of addpath capabilities negotiation, following checks 1. DUT sets value for the Send/Receive field as "3" during capabilities negotiation to signal support for both Send and Receive ability for multiple paths. 2. DUT sets value for the Send/Receive field as "1" during capabilities negotiation to signal support for Receive ability for multiple paths. 3. DUT sets value for the Send/Receive field as "2" during capabilities negotiation to signal support for Send ability for multiple paths.
Pull Request Test Coverage Report for Build 5362001056
💛 - Coveralls |
## Summary This test checks for DUT functionality of BGP addpath capability. It also confirms accuracy of addpath capabilities negotiation, following checks 1. DUT sets value for the Send/Receive field as "3" during capabilities negotiation to signal support for both Send and Receive ability for multiple paths. 2. DUT sets value for the Send/Receive field as "1" during capabilities negotiation to signal support for Receive ability for multiple paths. 3. DUT sets value for the Send/Receive field as "2" during capabilities negotiation to signal support for Send ability for multiple paths. 4. Tests are conducted at scale of 1M v4 and 600k v6 routes with 64 different NHs each. Also, routes are withdrawn at scale to ensure addpath functionality is maintained at scale. Multipath is also enabled on the DUT to extend addpath functionalities implications on FIB programming at scale.
rszarecki
requested changes
Jul 20, 2023
Co-authored-by: rszarecki <46606165+rszarecki@users.noreply.github.com>
Co-authored-by: rszarecki <46606165+rszarecki@users.noreply.github.com>
Updated test to remove Test-3
rszarecki
requested changes
Sep 13, 2023
There was a problem hiding this comment.
2 general comments:
- Test-2 is blending capabilities to negotiate send-only, recive-only with sclae. It shall be broken into two tests 2 - unidir add-path and 3 - scale
- I do not see any validation of "multipath".
- it is not clear if you think andout "ad-path multipat" that ensutes that only active (but not backup) path are advertised, or you mean "multipath" as DUT ability to perform loadbalancing on multiple path for same prefix, but do not impact add-path advertisment (so active and non-active path are sent upto the limit)
- Is it posible to re-design tets to use 4 ports? We do not have too many testbeds with > 4 ports. It may be hard to get reservation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This test checks for DUT functionality of BGP addpath capability. It also confirms accuracy of addpath capabilities negotiation, following checks