Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cisco dp 1.4 #1000

Closed
wants to merge 6 commits into from
Closed

Cisco dp 1.4 #1000

wants to merge 6 commits into from

Conversation

saarvind6481
Copy link
Contributor

This testcase adds the qos configs for cisco box and verifying the stats

@saarvind6481 saarvind6481 requested review from a team as code owners January 20, 2023 19:57
@google-cla
Copy link

google-cla bot commented Jan 20, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@sezhang2
Copy link
Contributor

/gcbrun

@sezhang2 sezhang2 self-assigned this Jan 23, 2023
@sezhang2
Copy link
Contributor

@saarvind6481 Please ping me @sezhang2 (sezhang@google.com) to discuss the config.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3989572266

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 120 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-1.4%) to 50.147%

Files with Coverage Reduction New Missed Lines %
topologies/binding/new.go 47 0%
topologies/binding/binding.go 73 40.41%
Totals Coverage Status
Change from base Build 3963575309: -1.4%
Covered Lines: 854
Relevant Lines: 1703

💛 - Coveralls

@sezhang2
Copy link
Contributor

/gcbrun

@sezhang2
Copy link
Contributor

Please rebase your PR to pick the latest changes

@sezhang2
Copy link
Contributor

/gcbrun

@saarvind6481 saarvind6481 deleted the cisco-dp-1.4 branch February 15, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants