Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix scan-build require line #16

Merged
merged 1 commit into from
Apr 25, 2020
Merged

Fix scan-build require line #16

merged 1 commit into from
Apr 25, 2020

Conversation

serge-sans-paille
Copy link
Collaborator

No description provided.

@sylvestre
Copy link
Collaborator 

    LLVM regression suite :: scanbuild_missing_delete.cpp

is that expected?

@serge-sans-paille
Copy link
Collaborator Author

no, that's what I'm trying to fix :-)

Fix scan-build test case
c29640e 
Fix requires and features and scan-view run.
@serge-sans-paille
Copy link
Collaborator Author

Finally works, yay!

sylvestre
sylvestre reviewed Apr 25, 2020
View reviewed changes
tests/scanbuild_missing_delete.cpp
// RUN: mkdir %t.out && cd %t.out && rm -rf *
// RUN: %scan-build -o . %clangxx -c %s -o %t
// It's not super satisfying to call sh like this, and not portable on windows.
// Yet that's the only I found to cope with the lack of support for '&' in lit.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ugly indeed :)

@sylvestre sylvestre merged commit 4fede9b into master Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sylvestre sylvestre sylvestre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@serge-sans-paille @sylvestre