-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
S390x compatibility fixes #109
S390x compatibility fixes #109
Conversation
Running this branch on a s390x system running latest Fedora Rawhide and LLVM 18.1.0~rc4 shows no failures:
|
@sylvestre Could you take a look at the cmake logic and double check if it's a good way to approach the libomp detection? |
From LLVM 18, libomp is supported in s390x. Previously all the libomp related tests were marked as XFAIL for s390x, which is no longer valid and marks passing tests as failures. With the libomp detection and a new REQUIRE rule for them the XFAIL is no longer needed.
Also document missing ENABLE_STATIC_LIBCXX and fix typo for ENABLE_LIBUNWIND
With the new s390x support for lld these testcases run now but are expected to fail as '-rtlib=compiler-rt' will fail due to unsupported builtins in the arch
408f804
to
73acffe
Compare
@nikic pointed out internally that detecting libomp using |
@sylvestre ping, pretty please? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I'm not a maintainer of this project, I did take a look at this PR.
With this PR, no tests fail on s390x.
Nice catch fixing the missing documentation!
The tests failing on Ubuntu are unrelated to this PR.
sorry, i missed your notif?! |
With the new support (LLVM-18) for libomp and lld in s390x there are now tests that are unexpectedly passing (marked as failure), others that are not being run. The summary of changes in this PR is as follows:
find_library
.libomp
feature added in lit.site.cfg. This is enabled depending on LIBOMP provided from cmake configuration.REQUIRES: libomp
lit directive. These tests will now be marked UNSUPPORTED in s390x/LLVM < 18, and will run normally on LLVM >= 18lld
being supported. These tests are expected to fail, as building with-rtlib=compiler-rt
will fail due to unsupportedbuiltins
library in the arch. Added XFAIL: s390x on them.Additionally, fedora workflow in GH actions has been updated with latest supported versions.