Skip to content

[c,z]dotc => [cc,zz]dotc #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 17, 2022
Merged

[c,z]dotc => [cc,zz]dotc #346

merged 2 commits into from
Apr 17, 2022

Conversation

prj-
Copy link
Contributor

@prj- prj- commented Mar 29, 2022

Pull request purpose

macOS portability

Detailed changes proposed in this pull request

See also Reference-ScaLAPACK/scalapack#51.

@fghoussen
Copy link
Collaborator

CI down, no solution for now (#341). We can't accept more PR. @sylvestre: what do you think? Can you handle this?

@prj-
Copy link
Contributor Author

prj- commented Apr 2, 2022

Just some historical consideration. This portability fix is in FreeFEM for as long as I can remember (https://github.com/FreeFem/FreeFem-sources/blob/07f5919c8ccb6db94cc7fc20fc6b7931c64737e5/3rdparty/arpack/Makefile.am#L72). For two years (https://github.com/FreeFem/FreeFem-sources/blob/6307e79edfb7f7f4f4ee78e3339977066139e5ab/3rdparty/ff-petsc/Makefile#L92), I'm using my fork through SLEPc --download-arpack which has this patch, so this has been thoroughly tested already. @joseeroman suggested that I get this merged here so that I don't have to maintain my fork anymore and also this will benefit to (SLEPc + ARPACK) \ FreeFEM users.

@prj-
Copy link
Contributor Author

prj- commented Apr 10, 2022

@fghoussen, I've rebased, could you please run the workflow?

@sylvestre
Copy link
Contributor

done

@fghoussen
Copy link
Collaborator

fghoussen commented Apr 10, 2022

@prj-: can you update the change log?

@prj-
Copy link
Contributor Author

prj- commented Apr 11, 2022

Done.

@prj-
Copy link
Contributor Author

prj- commented Apr 12, 2022

@fghoussen, could you please restart the workflow and approve/comment?

John Doe
@fghoussen fghoussen merged commit a5155ee into opencollab:master Apr 17, 2022
@prj-
Copy link
Contributor Author

prj- commented Apr 17, 2022

Thank you! I'll get this integrated in SLEPc now and will not have to update my fork anymore.

@prj- prj- deleted the jolivet/fix-dotc branch April 17, 2022 19:57
@fghoussen
Copy link
Collaborator

Don't hesitate to PR patches back here! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants