Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script for rotating circleci keys #172

Merged
merged 1 commit into from
Jan 10, 2023
Merged

Script for rotating circleci keys #172

merged 1 commit into from
Jan 10, 2023

Conversation

amebel
Copy link
Contributor

@amebel amebel commented Jan 10, 2023

Script to help deal with recurring circleci security issues.

@linas Details of most recent one can be found at https://circleci.com/blog/january-4-2023-security-alert/

@amebel amebel merged commit 7042a31 into opencog:master Jan 10, 2023
@amebel amebel deleted the circle-ci-key-rotation branch January 10, 2023 22:01
@linas
Copy link
Member

linas commented Jan 11, 2023

Thank you @amebel !

The list of repos starting at line 20 is incomplete; The most important missing are these: atomspace-rocks atomspace-cog link-grammar unify learn ... is it safe to add these, or will this mess up other configuration?

@amebel
Copy link
Contributor Author

amebel commented Jan 11, 2023

The repos listed had circleci build already enabled on their site.

If you are planning to enable ci for the repos you listed, I suggest you use github actions. Circleci have had a couple of security issues within the last year. I had moved docker image builds to github actions a while ago and it is working fine. See https://github.com/opencog/docker/tree/master/.github/workflows for configurations.

@linas
Copy link
Member

linas commented Jan 11, 2023

Cool. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants