This repository was archived by the owner on Jan 11, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 183
Add hover effect to footer icon fixes #344 #346
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
Collaborator
Author
|
@ananya-agrawal please review |
Contributor
|
@anupm12 haha this was creative, though I was thinking to make the icons become bold when hovered on. Try hovering on the fb, github, twitter icon of the backside of participants cards |
Collaborator
Author
|
@ananya-agrawal done |
Collaborator
Author
|
@prateek76 please review |
prateek76
suggested changes
Feb 3, 2019
Contributor
prateek76
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reduce the scaling @anupm12 and also transition time
Collaborator
Author
|
@prateek76 I have given 1.5 scale as of now |
Contributor
|
#347 i left a comment there |
Collaborator
Author
|
@prateek76 ok. |
Collaborator
Author
|
@prateek76 Please review now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you read the instructions in README ?
Yes
Solves which issue ?
Fixes #344
Give discription.
[Write Here. Be Specific]
Checklist
(To mark the checkboxes use
xwithin the box brackets)Signed the code of conduct.
Have you added yourself to the participants.
Joined opencode zulip server.