Skip to content
This repository was archived by the owner on Jan 11, 2020. It is now read-only.

Conversation

@anupm12
Copy link
Collaborator

@anupm12 anupm12 commented Feb 2, 2019

  • Please fill out the template below

Did you read the instructions in README ?

Yes

Solves which issue ?

Fixes #344

Give discription.

[Write Here. Be Specific]

Checklist

(To mark the checkboxes use x within the box brackets)

  • Signed the code of conduct.

  • Have you added yourself to the participants.

  • Joined opencode zulip server.

@opencodebot opencodebot bot requested a review from aswanthkoleri February 2, 2019 14:33
@anupm12
Copy link
Collaborator Author

anupm12 commented Feb 2, 2019

@anupm12
Copy link
Collaborator Author

anupm12 commented Feb 2, 2019

@ananya-agrawal please review

@ananya
Copy link
Contributor

ananya commented Feb 2, 2019

@anupm12 haha this was creative, though I was thinking to make the icons become bold when hovered on. Try hovering on the fb, github, twitter icon of the backside of participants cards

@anupm12
Copy link
Collaborator Author

anupm12 commented Feb 2, 2019

@ananya-agrawal done

@anupm12
Copy link
Collaborator Author

anupm12 commented Feb 3, 2019

@prateek76 please review

Copy link
Contributor

@prateek76 prateek76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reduce the scaling @anupm12 and also transition time

@anupm12
Copy link
Collaborator Author

anupm12 commented Feb 3, 2019

@prateek76 I have given 1.5 scale as of now
Shall I reduce it to 1.2 or should it be even less than that?

@prateek76
Copy link
Contributor

#347 i left a comment there

@anupm12
Copy link
Collaborator Author

anupm12 commented Feb 3, 2019

@prateek76 ok.

@anupm12
Copy link
Collaborator Author

anupm12 commented Feb 3, 2019

@prateek76 Please review now.

@prateek76 prateek76 merged commit e9d4249 into opencodeiiita:master Feb 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants