fix: get status_code for http exceptions #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enicioli
force-pushed
the
http-exception-code
branch
2 times, most recently
from
1ca418d to
9b81742
Compare
fainohub
approved these changes
Oct 27, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where HTTP exceptions were always reported with a 500 status code in metrics, regardless of their actual status code. Now the middleware intelligently checks if an exception's code represents a valid HTTP status and uses it when appropriate, falling back to 500 for invalid codes.
Key changes:
- Modified
MetricMiddlewareto extract and validate HTTP status codes from exceptions - Added helper methods to determine if an exception code is a valid HTTP status
- Enhanced test coverage with a data provider testing multiple exception code scenarios
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Middleware/MetricMiddleware.php | Added logic to extract valid HTTP status codes from exceptions and introduced helper methods for validation |
| tests/Unit/Middleware/MetricMiddlewareTest.php | Converted exception test to use data provider covering default, valid HTTP, and custom exception codes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lucas-angeli-gimenes
approved these changes
Oct 27, 2025
enicioli
force-pushed
the
http-exception-code
branch
from
9b81742 to
a1586eb
Compare
GiseleTrizotte
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request enhances the way HTTP status codes are reported in metrics when exceptions occur in the
MetricMiddleware. Instead of always reporting a 500 status code for exceptions, the middleware now checks if the exception code corresponds to a valid HTTP status and uses it when appropriate. The test suite is updated to verify this new behavior with multiple exception codes.Context
This change is particularly impactful in contexts where the application employs custom exception handlers to intercept exceptions and explicitly set the HTTP status code of the response.
Type of change
Checklist
feat: add SQS aspect)composer testpasses locally