Skip to content

Conversation

@enicioli
Copy link
Contributor

@enicioli enicioli commented Oct 15, 2025

Description

Explain what this PR does and why it is needed.

Type of change

  • Bug fix
  • New feature
  • Documentation
  • Performance/Refactor
  • CI/CD/Chore

Checklist

  • Title follows Conventional Commits (e.g., feat: add SQS aspect)
  • Tests added/updated
  • composer test passes locally
  • Documentation updated (README/Docs)
  • No breaking changes (or documented if any)

Related issues

Closes #, Relates to #

Copilot AI review requested due to automatic review settings October 15, 2025 23:41
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the data type inconsistency for HTTP status codes in metrics by changing them from strings to integers. The change ensures that status codes are consistently represented as numeric values rather than string representations.

  • Changes status code attributes from string format (e.g., '200', '500') to integer format (e.g., 200, 500)
  • Updates both the production middleware code and corresponding test expectations

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/Middleware/MetricMiddleware.php Removes string casting of status codes and uses hardcoded integer 500 for exceptions
tests/Unit/Middleware/MetricMiddlewareTest.php Updates test expectations to match integer status codes

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@enicioli enicioli force-pushed the fix-status_code-int branch from 3dc6f34 to 50859a0 Compare October 16, 2025 00:04
@enicioli enicioli merged commit ae8c2ac into main Oct 16, 2025
@enicioli enicioli deleted the fix-status_code-int branch October 16, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants