Fix help menu key binding - enable both Ctrl+? and Ctrl+H #211
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The help menu was not responding when users pressed
Ctrl+?
as documented, particularly affecting Windows/PowerShell users. This was due to terminal key mapping differences whereCtrl+?
gets interpreted as different key codes than expected.Root Cause Analysis
Through debugging, we discovered that:
Ctrl+?
was being interpreted as ESC (key code 27) in Windows/PowerShellCtrl+H
was being interpreted as backspace (key code 127) which works reliablySolution
✅ Enhanced key binding system that supports both shortcuts:
Ctrl+?
- Now works via intelligent ESC key handling when no dialogs are openCtrl+H
- Works reliably as primary alternative across all terminalsctrl+/
,ctrl+_
,delete
,backspace
for maximum compatibility✅ Smart ESC handling:
Ctrl+?
for help✅ Updated documentation and UI:
ctrl+?/ctrl+h help
indicating both shortcuts workCtrl+?
/Ctrl+H
as working help shortcutsCtrl+A
toCtrl+S
Testing Results
Ctrl+?
now works on Windows/PowerShell (via intelligent ESC handling)Ctrl+H
works reliably across all terminal environmentsTechnical Implementation
Key Binding Strategy
Intelligent ESC Handling
Impact
Files Changed
internal/tui/tui.go
- Enhanced help key bindings + intelligent ESC handlinginternal/tui/components/core/status.go
- Updated status bar to show both shortcutsREADME.md
- Updated documentation for correct shortcutsUser Experience
Users can now reliably access the help menu using either:
Ctrl+?
(the originally documented shortcut) ✅Ctrl+H
(reliable cross-platform alternative) ✅Both shortcuts display a comprehensive help dialog with all available keyboard shortcuts.
Closes: Issue where help menu was inaccessible to Windows/PowerShell users
Resolves: Cross-platform terminal key mapping inconsistencies for help access