Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fastFVA #560

Merged
merged 209 commits into from
Jun 16, 2017
Merged

fastFVA #560

merged 209 commits into from
Jun 16, 2017

Conversation

laurentheirendt
Copy link
Contributor

Integration of (internal) fastFVA version that has been adapted from original version:

  • user-friendly MEX file generation on UNIX and Windows systems
  • dynamic parameters
  • parallel computation tracking
  • distribution strategies
  • test & documentation
  • integration with CI

I hereby confirm that I have:

  • Tested my code on my own machine
  • Followed the guidelines in the Contributing Guide
  • Selected develop as a target branch (top left drop-down menu)

cc: @ithiele, @stefaniamagg , @maikeaurich, @marouenbg

Added Linux compilation support for GLPK and ILOG CPLEX.
Tomlab/CPLEX not support (yet)
Test version - several compilation warnings.
Updated support for the compilation on Windows 8 & CPLEX.
Adapted the parallelizing function to R2014b+.
Added support to set CPLEX parameters.
Significant improvement of running speeds on Linux OS.
Minor modifications for running numerical experiments.
@laurentheirendt
Copy link
Contributor Author

Closing temporarily for further changes.

@codecov-io
Copy link

codecov-io commented Jun 16, 2017

Codecov Report

Merging #560 into develop will increase coverage by 1.01%.
The diff coverage is 71.09%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #560      +/-   ##
===========================================
+ Coverage    24.89%   25.91%   +1.01%     
===========================================
  Files          621      611      -10     
  Lines        38008    37486     -522     
===========================================
+ Hits          9463     9714     +251     
+ Misses       28545    27772     -773
Impacted Files Coverage Δ
src/modelAnalysis/FVA/fastFVA/cleanFilesFastFVA.m 0% <0%> (ø)
src/base/solvers/changeCobraSolver.m 76.36% <100%> (+4.93%) ⬆️
src/modelAnalysis/sampling/chrrSampler.m 75% <100%> (+11.36%) ⬆️
src/base/solvers/getCPLEXversion.m 72.22% <72.22%> (ø)
src/modelAnalysis/FVA/fastFVA/fastFVA.m 75.09% <75.09%> (ø)
src/base/setWorkerCount.m 76.92% <76.92%> (ø)
src/modelAnalysis/sampling/sampleCbModel.m 73.23% <0%> (-5.17%) ⬇️
src/base/io/utilities/convertOldStyleModel.m 77.96% <0%> (-1.73%) ⬇️
src/base/solvers/solveCobraNLP.m 37.34% <0%> (-1.17%) ⬇️
...Analysis/multiSpecies/createMultipleSpeciesModel.m 91.13% <0%> (-0.91%) ⬇️
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a97207e...6fa43d9. Read the comment docs.

@syarra
Copy link
Contributor

syarra commented Jun 16, 2017

Waooo 🎆 Great job @laurentheirendt!
It's awesome to have fastFVA in The COBRA Toolbox!

@syarra syarra merged commit 2e86eec into opencobra:develop Jun 16, 2017
@marouenbg
Copy link
Contributor

marouenbg commented Jun 16, 2017

nice catch @laurentheirendt !! 🐲

@laurentheirendt laurentheirendt deleted the add-fastFVA-3 branch June 19, 2017 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants