Update to SBML 5.16 #1054
Merged
Update to SBML 5.16 #1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1054 +/- ##
===========================================
+ Coverage 41.76% 41.81% +0.04%
===========================================
Files 809 764 -45
Lines 59216 56480 -2736
===========================================
- Hits 24730 23615 -1115
+ Misses 34486 32865 -1621
Continue to review full report at Codecov.
|
laurentheirendt
suggested changes
Dec 11, 2017
src/base/io/writeCbModel.m
Outdated
| else | ||
| if strcmp(format,'toselect') % no format was given. try to detect from fileName. | ||
| [~, ~, extension] = fileparts(fileName); | ||
| switch extension |
There was a problem hiding this comment.
May you put this switch in an internal function?
initCobraToolbox.m
Outdated
| end | ||
|
|
||
|
|
||
| function adaptMacPath() |
There was a problem hiding this comment.
May you put this function as a separate function in base?
|
Thanks for the comments. Is this what you wanted? |
|
So all tests pass, but codecov fails and thus the default? |
|
Close/Reopen to retrigger the CI |
laurentheirendt
approved these changes
Dec 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to SBML 5.16
This update includes:
Corrected IO for subSystems (they are now exported via the groups plugin - in accordance with BiGG models). They can now also be read from those.
Fixed issues with macOS high Sierra/Sierra and current Matlab versions.
SBML IO should work now with all current Matlab/macOS combinations indicated by mathworks.
I hereby confirm that I have:
developas a target branch (top left drop-down menu)(Note: You may replace [] with [X] to check the box)