Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/core group #1173

Merged
merged 3 commits into from
Mar 10, 2022
Merged

Refactor/core group #1173

merged 3 commits into from
Mar 10, 2022

Conversation

akaviaLab
Copy link
Contributor

  • description of feature/fix
    updated group.py and test_group.py to Python 3.6+ compliant code.

@Midnighter
Copy link
Member

As always, thank you for your contributions to cobrapy. I'm a bit overwhelmed with all this activity 🙂 It's way more than what I usually spend on cobrapy. @synchon can you maybe review these code updates? You've done a lot of them yourself and I would really appreciate the help.

@synchon
Copy link
Member

synchon commented Mar 10, 2022

@Midnighter yeah sure, I can review the updates.

src/cobra/core/group.py Outdated Show resolved Hide resolved
src/cobra/core/group.py Outdated Show resolved Hide resolved
src/cobra/core/group.py Outdated Show resolved Hide resolved
src/cobra/core/group.py Outdated Show resolved Hide resolved
src/cobra/core/group.py Outdated Show resolved Hide resolved
Copy link
Member

@synchon synchon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments before it's ready. Also, would be nice if you could please run tox -e flake8 to fix the flake8 complaints.

@synchon
Copy link
Member

synchon commented Mar 10, 2022

Looks like the PR is not rebased on the latest devel. Can you please rebase it on the latest devel?

@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2022

Codecov Report

Merging #1173 (ee22104) into devel (0b3f792) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            devel    #1173      +/-   ##
==========================================
- Coverage   84.06%   84.06%   -0.01%     
==========================================
  Files          65       65              
  Lines        5353     5352       -1     
  Branches     1236     1236              
==========================================
- Hits         4500     4499       -1     
  Misses        545      545              
  Partials      308      308              
Impacted Files Coverage Δ
src/cobra/core/group.py 89.18% <100.00%> (-0.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b3f792...ee22104. Read the comment docs.

@akaviaLab
Copy link
Contributor Author

Should be rebased now. The commits appear four times because that's what rebasing does on my computer. Gah.

Copy link
Member

@synchon synchon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you for the contribution!

@synchon synchon merged commit 0cda5d2 into opencobra:devel Mar 10, 2022
@akaviaLab akaviaLab deleted the refactor/core_group branch April 25, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants