-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/core group #1173
Refactor/core group #1173
Conversation
As always, thank you for your contributions to cobrapy. I'm a bit overwhelmed with all this activity 🙂 It's way more than what I usually spend on cobrapy. @synchon can you maybe review these code updates? You've done a lot of them yourself and I would really appreciate the help. |
@Midnighter yeah sure, I can review the updates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments before it's ready. Also, would be nice if you could please run tox -e flake8
to fix the flake8
complaints.
Looks like the PR is not rebased on the latest |
Codecov Report
@@ Coverage Diff @@
## devel #1173 +/- ##
==========================================
- Coverage 84.06% 84.06% -0.01%
==========================================
Files 65 65
Lines 5353 5352 -1
Branches 1236 1236
==========================================
- Hits 4500 4499 -1
Misses 545 545
Partials 308 308
Continue to review full report at Codecov.
|
Should be rebased now. The commits appear four times because that's what rebasing does on my computer. Gah. |
10d080a
to
ee22104
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thank you for the contribution!
updated group.py and test_group.py to Python 3.6+ compliant code.