refactor: cobra.io.json #1151
Merged
refactor: cobra.io.json #1151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To be merged after #1134 is merged. |
Midnighter
requested changes
Feb 17, 2022
There was a problem hiding this comment.
src/cobra/__init__.py:17: in <module>
from cobra import io
src/cobra/io/__init__.py:5: in <module>
from cobra.io.json import from_json, load_json_model, save_json_model, to_json
src/cobra/io/json.py:5: in <module>
from ..dict import model_from_dict, model_to_dict
E ModuleNotFoundError: No module named 'cobra.dict'
Midnighter
reviewed
Feb 17, 2022
src/cobra/io/json.py
Outdated
|
|
||
| from cobra.io.dict import model_from_dict, model_to_dict | ||
| from ..dict import model_from_dict, model_to_dict |
There was a problem hiding this comment.
Suggested change
| from ..dict import model_from_dict, model_to_dict | |
| from .dict import model_from_dict, model_to_dict |
There was a problem hiding this comment.
Shoot! Missed it. Sending a fix now.
synchon
force-pushed
the
refactor/io-json
branch
from
fa94ecf
to
5b07b38
Compare
|
Checks were taking some time, hence rebased it on latest devel. |
Midnighter
approved these changes
Feb 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds typing annotations for cobra.io.json and its unit tests. It also upgrades the code style for them to maintain Python 3.6+ compatibility.