feat: collabora insert images from opencloud #924
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for inserting images from OpenCloud into Collabora by extending file actions and refactoring the file picker for reusable callbacks, and includes environment variable updates.
- Introduces
onFilePickedcallback flow inuseFileActionsOpenWithAppfor launching editor routes - Refactors
FilePickerModalto acceptallowedFileTypesandcallbackFn, removing app-specific logic - Integrates new
UI_InsertGraphicpostMessage handling in the external app to open the file picker and insert graphics - Adds default environment variables in
docker-compose.ymlfor URL signing and proxy log level
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| packages/web-pkg/src/composables/actions/files/useFileActionsOpenWithApp.ts | Added allowedFileTypes and onFilePicked handler to open editor |
| packages/web-pkg/src/components/Modals/FilePickerModal.vue | Updated props to use allowedFileTypes/callbackFn, removed dead code |
| packages/web-app-external/src/App.vue | Imported FilePickerModal, added UI_InsertGraphic handling and debug logs |
| docker-compose.yml | Added OC_URL_SIGNING_SHARED_SECRET, PROXY_LOG_LEVEL, and aliasgroup1 |
Comments suppressed due to low confidence (1)
docker-compose.yml:189
- [nitpick] Environment variable
aliasgroup1does not follow convention of uppercase with underscores; consider renaming toALIAS_GROUP_1or documenting its format.
aliasgroup1: https://.*:443
AlexAndBear
force-pushed
the
issues/704
branch
4 times, most recently
from
2146eeb to
a6e756a
Compare
Contributor
Author
|
This pr fulfils the acceptance criteria, unfortunately it doesn't work with self signed certificates, need to clarify with collabora. cc @kulmann |
|
There seem to be a couple of issues with Collabora currently. When trying this with Collabora 25.04.2.1.1 (the one we're currently using in our compose examples). I was not able to get this to work at all. The latest version I could get it to work with was the docker tag To make it work you have to add the hostname of the opencloud instance ot the To enable debug logging of the image download I changed the When using 24.04.8.2.1 (or any older 24.04. release) with self-signed certificates I get this in the collabora logs: Clearly stating that there's a problem with the certificate of Once I switch to proper certificates inserting an images works just fine. And I get this in the logs, indicating a proper download using the signedurl: Any Collabora version newer than 24.04.8.2.1 just gives we this single line related to downloading the image, regardless of self-signed or proper certificates: |
AlexAndBear
force-pushed
the
issues/704
branch
from
8b5362f to
527d644
Compare
|
Just for completeness: With this patch and opencloud-eu/opencloud#1692 I could get the feature to work. It's still not working when using self-signed certificates though. For whatever reason collabora refuses the certificate even if |
AlexAndBear
force-pushed
the
issues/704
branch
from
9cadea9 to
a3a2f29
Compare
|
@AlexAndBear @kulmann Can we merge this already? Even if we'd decide to not enable the feature for now I guess it won't do any harm, will it? I am currently getting opencloud-eu/opencloud#1692 into shape so that we can merge it and add the missing pieces to the compose files. |
Contributor
Author
|
@rhafer We can after reviewing, what is the plan with https://github.com/opencloud-eu/web/pull/924/files#diff-e45e45baeda1c1e73482975a664062aa56f20c03dd9d64a827aba57775bed0d3R17 will this be mandatory or can I remove it from the docker compose file ? Do you still have a working instance with propper certificates somewhere? This would help the team while reviewing this pr |
The plan is to have
Yes, that's still available. |
JammingBen
approved these changes
Oct 29, 2025
# Conflicts: # packages/web-app-external/src/App.vue # packages/web-pkg/src/components/Modals/FilePickerModal.vue
AlexAndBear
force-pushed
the
issues/704
branch
from
1191780 to
00e2b98
Compare
openclouders
pushed a commit
that referenced
this pull request
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
How Has This Been Tested?
Types of changes