Skip to content

Conversation

@ScharfViktor
Copy link
Contributor

@ScharfViktor ScharfViktor commented Jul 8, 2025

  • Disabled the welcome pop-up window for tests. I tried different methods, but found only one that works: replace usr/share/coolwsd/browser/dist/welcome to empty folder

I found another way: param --o:home_mode.enable=true disables popup but limits number of concurrent open connections to 20 that I find not problem for our tests

here is from coolwsd.xml

<home_mode>
        <enable desc="Home users can enable this setting, which in turn disables welcome screen and user feedback popups, but also limits concurrent open connections to 20 and concurrent open documents to 10. The default means that number of concurrent open connections and concurrent open documents are unlimited, but welcome screen and user feedback cannot be switched off." type="bool" default="false">false</enable>
    </home_mode>
  • second popup our browser has very limited access to the clipboard, so please use the paste buttons on your on-screen keyboard instead I handle with tryCopyClipboard()

how result: tests became faster 2m52 and, hopefully, more stable

Copilot AI review requested due to automatic review settings July 8, 2025 15:05
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses flakiness in end-to-end tests by suppressing Collabora’s welcome modals and improving clipboard-copy reliability.

  • Refactors E2E test helpers to remove ad-hoc popup handling and introduce a retry-based tryCopyClipboard function
  • Mounts an empty welcome directory in both local Docker and Woodpecker CI to disable the welcome screen
  • Removes obsolete selectors and in-test escape logic

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.

File Description
tests/e2e/support/objects/app-files/resource/actions.ts Removed manual popup handlers, added tryCopyClipboard helper
docker-compose.yml Added volume mount for empty welcome folder
.woodpecker.star Added CI volume mount for empty welcome folder
Comments suppressed due to low confidence (2)

tests/e2e/support/objects/app-files/resource/actions.ts:500

  • Consider adding a JSDoc comment to explain the purpose of tryCopyClipboard, its parameters, and retry logic for improved readability and maintenance.
const tryCopyClipboard = async (page: Page, maxRetries = 5): Promise<string> => {

.woodpecker.star:1356

  • [nitpick] Ensure the relative volume path in CI config resolves correctly; adding a leading ./ might prevent path resolution issues on different runners.
                "tests/woodpecker/collabora/no_welcome:/usr/share/coolwsd/browser/dist/welcome:ro",

@ScharfViktor ScharfViktor changed the title [full-ci] e2e tests. fix app-provider flaky test [full-ci] e2e tests. fix app-provider flaky test. Disable welcome popup Jul 10, 2025
Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care!

@JammingBen JammingBen merged commit 74a568e into main Jul 11, 2025
25 checks passed
@JammingBen JammingBen deleted the app-providerFlaky branch July 11, 2025 05:02
@openclouders openclouders mentioned this pull request Jul 11, 2025
1 task
@openclouders openclouders mentioned this pull request Jul 21, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants