-
Notifications
You must be signed in to change notification settings - Fork 25
[full-ci] e2e tests. fix app-provider flaky test. Disable welcome popup #917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses flakiness in end-to-end tests by suppressing Collabora’s welcome modals and improving clipboard-copy reliability.
- Refactors E2E test helpers to remove ad-hoc popup handling and introduce a retry-based
tryCopyClipboardfunction - Mounts an empty
welcomedirectory in both local Docker and Woodpecker CI to disable the welcome screen - Removes obsolete selectors and in-test escape logic
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/e2e/support/objects/app-files/resource/actions.ts | Removed manual popup handlers, added tryCopyClipboard helper |
| docker-compose.yml | Added volume mount for empty welcome folder |
| .woodpecker.star | Added CI volume mount for empty welcome folder |
Comments suppressed due to low confidence (2)
tests/e2e/support/objects/app-files/resource/actions.ts:500
- Consider adding a JSDoc comment to explain the purpose of
tryCopyClipboard, its parameters, and retry logic for improved readability and maintenance.
const tryCopyClipboard = async (page: Page, maxRetries = 5): Promise<string> => {
.woodpecker.star:1356
- [nitpick] Ensure the relative volume path in CI config resolves correctly; adding a leading
./might prevent path resolution issues on different runners.
"tests/woodpecker/collabora/no_welcome:/usr/share/coolwsd/browser/dist/welcome:ro",
894c99f to
2203d64
Compare
JammingBen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for taking care!
Disabled the welcome pop-up window for tests. I tried different methods, but found only one that works: replace usr/share/coolwsd/browser/dist/welcome to empty folderI found another way: param
--o:home_mode.enable=truedisables popup but limits number of concurrent open connections to 20 that I find not problem for our testshere is from
coolwsd.xmlour browser has very limited access to the clipboard, so please use the paste buttons on your on-screen keyboard insteadI handle withtryCopyClipboard()how result: tests became faster 2m52 and, hopefully, more stable