-
Notifications
You must be signed in to change notification settings - Fork 25
e2e tests. set space image using context menu #916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR extends the E2E test framework to support using the context menu for modifying space attributes (name, subtitle, description, quota, image) and adds icon setting/deletion flows.
- Updated page‐object methods (
Spaces) to accept acontextMenuflag and pass it through. - Updated action functions to branch between panel vs. context‐menu flows and added
changeSpaceIcon/deleteSpaceImage. - Updated Cucumber step definitions and feature scenarios for context‐menu use and icon/image deletion.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/e2e/support/objects/app-files/spaces/index.ts | Added contextMenu parameter to space‐modification methods. |
| tests/e2e/support/objects/app-files/spaces/actions.ts | Branched actions on contextMenu, added icon & delete‐image logic. |
| tests/e2e/cucumber/steps/ui/spaces.ts | New step definitions for context‐menu and icon/image deletion. |
| tests/e2e/cucumber/features/spaces/project.feature | Updated scenarios to invoke context‐menu flows and icon steps. |
Comments suppressed due to low confidence (2)
tests/e2e/cucumber/features/spaces/project.feature:41
- [nitpick] After deleting the space image, consider adding an assertion step to verify the image has been removed and the UI reflects the change.
And "Alice" deletes the space "team.1" image
tests/e2e/cucumber/features/spaces/project.feature:42
- [nitpick] Following the icon change step, add an assertion to confirm the new icon is displayed correctly in the UI for full end-to-end validation.
And "Alice" changes the space "team.1" icon to "😍"
a4a23b0 to
758cd01
Compare
AlexAndBear
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tysm 🚀
tests for: