feat: Collabora Save As and Export #859
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements Collabora’s Save As and Export functionality while refactoring file and folder name validations to use a centralized helper. Key changes include the introduction of the useIsResourceNameValid helper (and its integration in tests and file actions), removal of duplicate name validation logic in several components, and the addition of a new SaveAsModal component with Collabora-specific messaging in the app.
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/unit/composables/actions/helpers/useIsResourceNameValid.spec.ts | New tests validating resource name logic using the new helper |
| tests/unit/composables/actions/files/* | Removal of duplicated name validation tests and functions |
| src/composables/actions/helpers/useIsResourceNameValid.ts | New helper to centralize file/folder name validations |
| src/composables/actions/files/* | Refactored file actions to use the new helper |
| packages/web-app-external/src/components/SaveAsModal.vue | Added a new modal component for Save As/Export functionality |
| packages/web-app-external/src/App.vue | Integrated Collabora messaging and modal dispatch for file actions |
packages/web-pkg/src/composables/actions/helpers/useIsResourceNameValid.ts
Outdated
Show resolved
Hide resolved
kulmann
force-pushed
the
feat/collabora-save-as
branch
2 times, most recently
from
a54dafe to
66ff244
Compare
AlexAndBear
requested changes
Jun 26, 2025
kulmann
force-pushed
the
feat/collabora-save-as
branch
from
def39f9 to
988d2a8
Compare
AlexAndBear
requested changes
Jun 26, 2025
packages/web-pkg/src/composables/actions/helpers/useIsResourceNameValid.ts
Show resolved
Hide resolved
packages/web-pkg/src/composables/actions/helpers/useIsResourceNameValid.ts
Outdated
Show resolved
Hide resolved
kulmann
force-pushed
the
feat/collabora-save-as
branch
from
988d2a8 to
204c19f
Compare
AlexAndBear
approved these changes
Jun 26, 2025
Contributor
AlexAndBear
left a comment
AlexAndBear
left a comment
There was a problem hiding this comment.
very mindful, very demure 💅 ⭐
kulmann
force-pushed
the
feat/collabora-save-as
branch
2 times, most recently
from
dc9cac3 to
b5087cf
Compare
AlexAndBear
force-pushed
the
feat/collabora-save-as
branch
2 times, most recently
from
7703a53 to
5bff612
Compare
AlexAndBear
force-pushed
the
feat/collabora-save-as
branch
from
5bff612 to
0fb1c9f
Compare
openclouders
pushed a commit
that referenced
this pull request
Jun 27, 2025
* feat: Collabora Save As and Export --------- Co-authored-by: Alex Ackermann <abackermann91@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make use of
Save AsandExportin Collabora.Related Issue
Types of changes